fix update-langs, align naming - #440
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
marcalexiei
left a comment
marcalexiei
left a comment
There was a problem hiding this comment.
I left a few comments with follow-up improvements, but overall this looks good to me!
| if: | | ||
| github.repository == 'anuraghazra/github-readme-stats' || | ||
| github.repository == 'stats-organization/github-readme-stats' || | ||
| github.repository == 'stats-organization/github-stats-extended' |
There was a problem hiding this comment.
Considering anuraghazra#4895, can we remove the checks for anuraghazra/github-readme-stats and stats-organization/github-readme-stats?
The same would apply to generate-theme-readme and any other workflows that have similar checks.
| update-languages: | ||
| if: | | ||
| github.repository == 'anuraghazra/github-readme-stats' || | ||
| github.repository == 'stats-organization/github-readme-stats' || |
There was a problem hiding this comment.
Not strictly related to this PR, but since we're here, I'd consider archiving stats-organization/github-readme-stats now that anuraghazra#4895 has been merged.
There was a problem hiding this comment.
Considering that the workflows were broken due to the code changes, maybe we should also run these workflows on a schedule trigger.
They wouldn't open any PRs, but they would at least let us verify that the workflows are still working.
Alternatively, we could add unit tests for the scripts (easy to catch when updating deps).
Either approach should probably be explored in a separate PR and will help avoid regressions like the ones we just experienced.
There was a problem hiding this comment.
For now I added a cron trigger. generate-language-colors triggers more often than before, because GitHub can drop executions and we probably don't want to wait several months for an execution. And the trigger is not at 0:00 anymore, to avoid load peaks from other GitHub users, as recommended in the GitHub docs.
Adding unit tests also sounds good to catch problems with dependency upgrades before they get merged to master. I don't have time to create them at the moment, but in case you want to do this, you're very welcome.
2 participants
Like #433 for the update-langs workflow.