refactor(core): derive color param names from a single source of truth - #435
Merged
martin-mfg merged 1 commit intoAug 3, 2026
Merged
Conversation
|
@marcalexiei is attempting to deploy a commit to the martin-mfg's projects Team on Vercel. A member of the Team first needs to authorize it. |
martin-mfg
reviewed
Aug 3, 2026
| type ThemeVariant = "dark" | "light"; | ||
| type LightDarkColorParams = Partial< | ||
| Record<`${keyof ColorInput}_${ThemeVariant}`, string> | ||
| Record<`${BaseColorKey}_${ThemeVariant}`, string | undefined> |
Author
martin-mfg
merged commit Aug 3, 2026
3d02c3e
into
stats-organization:media-query
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Derive the color param names from one source of truth.
They were spelled out in different places:
ColorInputinterfaceextractLightDarkColorsmapping,COLOR_PARAM_KEYSarray,api/*.jsfiles.Adding a param meant touching all four, with nothing to catch a miss.
Now everything derives from:
ColorInputandLightDarkColorParamsbecome mapped types over those keys,extractLightDarkColorsmaps overBASE_COLOR_KEYS, andCOLOR_PARAM_KEYSis built by flat-mapping the variants.The api files each repeated the same "theme params aren't colors" exclusion:
That's now
findInvalidColorParam(colorParams), with the exclusion derived incolor.ts.