Draft
Port shared-partner changestats to the C++ term API#655
Conversation
Copilot
AI
changed the title
[WIP] Convert sp code to C++ template with updated MHproposals
Port shared-partner changestats to the C++ term API
Jul 1, 2026
Member
|
@copilot Also modify the sp_change() functions to use the C++ network API and incorporate them as templates. |
Contributor
Author
Member
|
@copilot Assume that changestats_dgw_sp.h will only ever be invoked from C++, and remove no-longer-used macros. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared-partner changestats were implemented as a dense C macro expansion over edgewise/dyadwise, six SP configurations, and three calculation modes. This change moves the public changestat entry points onto the C++ term API and updates the triadic proposal code to use the same shared-partner dispatch helpers.
C++ changestat entry points
src/changestats_dgw_sp.cwithsrc/changestats_dgw_sp.cpp.ddsp,dgwdsp,desp,dgwesp,dnsp, anddgwnspentry points (plus distribution/bipartite wrappers) toC_CHANGESTAT_CPP(...).Shared helper dispatch
src/changestats_dgw_sp.hto dispatchdsp*/esp*logic byL2Type.Triadic proposal update
src/MHproposals_triadic.cppto call the new shared-partner helper instead of expanding the legacy header macros directly.RTPbehavior in the proposal path.Example of the new dispatch style: