Fix CI and build with modern cmake#179
Merged
Merged
Conversation
Fixed the following: - updated the cmake_minimum_required() target version to 4.0 : 3.x deprecated - Upgraded external repos to use the latest from the 3d party libraries - Upgraded Catch2 tests to use the newer test infra - Removed obsolete [!hide] from the test descriptions - fixed a warning in "" operator overload.
use pixi which (at least for me) makes things easier to keep up to date and keep things closer to (my) developer experience. We do not test for varying versions of LLVM anymore (which were all extremely old by now anyway.) If this turns out to be problematic, we could easily add more versions of compilers and such in the pixi.toml file.
this commit is entirely vibe-coded with Claude.
this commit was vibe-coded with claude
this was mostly vibe-coded with claude
saraedum
force-pushed
the
ci
branch
3 times, most recently
from
abecf42 to
140d751
Compare
I don't fully understand what's going on here (Claude pretends to but I doubt it) but there are bizarre errors without a proper compile commands database here that seem entirely macOS specific. They seem to be due to using conda's compilers and not the one that ships with xcode but we want to support that use case both for the CI but also in general. Let's ignore this test therefore. The other integration test already tests a lot of stuff.
saraedum
commented
May 20, 2026
saraedum
commented
May 20, 2026
the URLs likely don't work anymore and downloading a fully functional binary here feels a bit optimistic imho anyway. I guess we can expect people to install LLVM through their system somehow (or use the pixi setup that ships it.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
includes #178