Skip to content

Switch majority of deb repos to verbatim mode#543

Merged
mnasiadka merged 2 commits into
mainfrom
grafana_verbatim
Jun 23, 2026
Merged

Switch majority of deb repos to verbatim mode#543
mnasiadka merged 2 commits into
mainfrom
grafana_verbatim

Conversation

@mnasiadka

Copy link
Copy Markdown
Member

Omitting RabbitMQ and Erlang - will handle them separately due to the comment.

Simple is too limited: Simple publishing forces everything into a single layout (default all), preventing you from separating packages into distinct suites (e.g., stable, testing) or components (e.g., main, contrib).

Since it's a 1:1 mirror - we should switch to verbatim which clones the upstream repo 1:1.

Omitting RabbitMQ and Erlang - will handle them separately due to the
comment.

Simple is too limited: Simple publishing forces everything into a
single layout (default all), preventing you from separating packages
into distinct suites (e.g., stable, testing) or components (e.g., main, contrib).

Since it's a 1:1 mirror - we should switch to verbatim which clones
the upstream repo 1:1.
@mnasiadka mnasiadka requested a review from a team as a code owner June 23, 2026 15:45
@mnasiadka mnasiadka merged commit 84c29e5 into main Jun 23, 2026
@mnasiadka mnasiadka deleted the grafana_verbatim branch June 23, 2026 15:45

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures several Debian package repositories in the Ansible inventory to use mirror: true and mode: verbatim. However, using mode: verbatim alongside filters like distributions, components, or architectures will cause client-side 404 Not Found errors because unmodified upstream metadata is published. To prevent broken repository metadata, you should use mode: structured instead, which correctly regenerates metadata for only the synced packages.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines 228 to 231
distributions: stable
components: main
mirror: true
mode: verbatim

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using mode: verbatim while filtering by distributions or components will result in broken repository metadata.

In Pulp (pulp_deb), verbatim publishing copies the upstream metadata files completely unmodified. If you filter the synced content (e.g., restricting to stable and main), the published metadata will still list packages for other distributions or components that were filtered out during sync. When client systems attempt to update or install packages, they will encounter 404 Not Found errors for any of the filtered-out packages.

To resolve this, you should use mode: structured instead. This preserves the repository's suite/component structure while regenerating the metadata to match only the actually synced packages.

    distributions: stable
    components: main
    mirror: true
    mode: structured

Comment on lines 240 to +244
architectures: amd64
distributions: stable
components: main
mirror: true
mode: verbatim

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using mode: verbatim while filtering by architectures (such as architectures: amd64) will result in broken repository metadata.

In Pulp (pulp_deb), verbatim publishing copies the upstream metadata files completely unmodified. If you filter the synced content (e.g., restricting to amd64), the published metadata will still list packages for other architectures (like arm64) that were filtered out during sync. When client systems attempt to update or install packages, they will encounter 404 Not Found errors for any of the filtered-out packages.

To resolve this, you should use mode: structured instead. This preserves the repository's suite/component structure while regenerating the metadata to match only the actually synced packages.

    architectures: amd64
    distributions: stable
    components: main
    mirror: true
    mode: structured

Comment on lines 253 to +257
architectures: amd64
distributions: stable
components: main
mirror: true
mode: verbatim

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using mode: verbatim with architectures: amd64 will cause client-side 404 errors for other architectures. Switch to mode: structured to ensure metadata is regenerated correctly for the synced packages.

    architectures: amd64
    distributions: stable
    components: main
    mirror: true
    mode: structured

Comment on lines 266 to +270
architectures: amd64
distributions: noble
components: main
mirror: true
mode: verbatim

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using mode: verbatim with architectures: amd64 will result in broken metadata for other architectures listed in the upstream metadata but not synced. Switch to mode: structured to regenerate the metadata correctly for the synced packages.

    architectures: amd64
    distributions: noble
    components: main
    mirror: true
    mode: structured

Comment on lines 288 to +292
distributions: noble
components: main
architectures: amd64
mirror: true
mode: verbatim

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using mode: verbatim with filters like architectures: amd64 will cause client-side 404 Not Found errors because the unmodified upstream metadata will reference packages (such as arm64 packages) that were filtered out during sync. Use mode: structured to safely regenerate the metadata for the synced architectures while preserving the repository structure.

    distributions: noble
    components: main
    architectures: amd64
    mirror: true
    mode: structured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant