Feature: Allow workloadKind: Deployment - #873
Open
Maleware wants to merge 7 commits into
Open
Conversation
1 task
Maleware
marked this pull request as ready for review
August 12, 2026 10:47
Maleware
marked this pull request as draft
August 12, 2026 10:47
Maleware
marked this pull request as ready for review
August 19, 2026 13:00
Maleware
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
Maleware
marked this pull request as draft
August 20, 2026 06:54
Member
Author
|
I turned it back into a draft so it cannot be merged by accident. Still ready for review. |
…rs.roleConfig Replaces the EmptyRoleConfig parameter of OpaRoleType with a product-specific OpaRoleConfig, as the extension point for deploying the servers role as either a DaemonSet or a Deployment (#525). The CRD half only - no builder, PDB or orphan-cleanup changes. Both internalTrafficPolicy and podDisruptionBudget.enabled are Options with a null default, because their effective default depends on workloadKind and an OpenAPI default cannot express that. The operator derives them instead: workloadKind | internalTrafficPolicy | podDisruptionBudget.enabled DaemonSet | Local | false Deployment | Cluster | true A hard-coded schema default would let the apiserver stamp a value in before the operator sees the object, so "user chose Local" and "user said nothing" would be indistinguishable. It would also create a PodDisruptionBudget on every existing DaemonSet installation at upgrade time, protecting nothing. Decision: stackabletech/decisions#91
Maleware
force-pushed
the
feat/opa-as-deployment
branch
from
September 2, 2026 16:06
47d0fa2 to
61b8c20
Compare
Member
Author
|
Maleware
marked this pull request as ready for review
September 2, 2026 16:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HINT: Takesspike/rifas base as changes overlap. Please merge #863 first.Allow opa being deployed as workload deployment.
This PR contains:
opaClusterbeing deployable either as workloadKindDaemonsetorDeploymentpodDisruptionBudgetsonly for workloadKindDeploymentDeploymentis used across all nodes if possibleDaemonset<>Deployment. Checks defaults forlocalTrafficPolicyis set correctly according toworkloadKindworkloadKindmechanism,PDBsand default affinities.Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker