chore: bump Rust edition to 2024 and apply cargo fix + clippy updates#943
Open
Saul-STFC wants to merge 8 commits into
Open
chore: bump Rust edition to 2024 and apply cargo fix + clippy updates#943Saul-STFC wants to merge 8 commits into
Saul-STFC wants to merge 8 commits into
Conversation
Run `cargo fix --edition` and resolve resulting warnings: - Add `use<>` syntax to `impl Trait` return types (auto-fixed) - Fix Rust 2024 temporary drop order change by simplifying `_initial_reconcile_rx` handling - Apply rustFMT suggestions
17 tasks
NickLarsenNZ
moved this from Development: In Progress
to Development: In Review
in Stackable Engineering
auto-merge was automatically disabled
July 1, 2026 07:18
Head branch was pushed to by a user without write access
Saul-STFC
force-pushed
the
rust-2024-upgrade
branch
from
e62b494 to
5486a64
Compare
NickLarsenNZ
reviewed
Jul 6, 2026
# Conflicts: # Cargo.toml # rust/operator-binary/src/controller.rs # rust/operator-binary/src/controller/build/jvm.rs # rust/operator-binary/src/controller/build/resource/reporting_task.rs
# Conflicts: # rust/operator-binary/src/nifi_controller.rs
Author
sbernauer
previously approved these changes
Jul 13, 2026
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.tech>
Author
|
Done @sbernauer |
sbernauer
approved these changes
Jul 13, 2026
sbernauer
left a comment
sbernauer
left a comment
Member
There was a problem hiding this comment.
IHMO this is such a small change that we can merge it before the release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run
cargo fix --editionand resolve resulting warnings:use<>syntax toimpl Traitreturn types (auto-fixed)_initial_reconcile_rxhandlingPart of Bump our Rust code to 2024 edition issues#832
Description
Please add a description here. This will become the commit message of the merge request later.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker