docs(source): resolve the second gate pass's remaining contract-doc findings - #206
Merged
Conversation
…indings P1: the Term row (README) and package-doc ack model now state that ErrTermInsideTransaction leaves the record unmarked and redelivered, so a hot-looping poison handler's failure mode is explicit on every surface that mentions the rejection. P2s: duplicate-settle semantics now specify arrival-order composition (a later Ack supersedes an earlier Nak for future commits; an already-issued re-seek may still yield one final at-least-once redelivery); settling a never-delivered or post-drain message is defined as backend-defined with Kafka's detection noted; violating Begin's only-settle-path rule is explicitly undefined behavior; and the Close doc wording no longer tensions with Next's buffered-yield clause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint 4.6 — gate rerun 2 findings resolved
Gate rerun 2 on
2931f24: implementation breaker all PASS, zero findings; release auditor all PASS; contract adversary 27 HELD / 0 BROKEN / 4 UNDOCUMENTED with one residual P1.This PR closes the P1 + all actionable P2s — documentation-only, zero behavior change:
ErrTermInsideTransactionunstated on README/package-doc surfacesinlet.go Settle: decisions compose in arrival order; later mark supersedes; in-flight re-seek may yield one final redeliveryPer gate rules the full three-panel gate reruns once more on this merge before tagging. Known environmental note from rerun 2 (not reproducible, machine contention during a concurrent run) recorded here for the release notes: one transient kafka unit-suite timeout, green on three consecutive reruns.