Add support for FTS#2127
Open
emilienbev wants to merge 9 commits into
Open
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Fixes #2085 Signed-off-by: Emilien Bevierre <emilien.bevierre@couchbase.com>
…tites and totalRows in a single round trip Signed-off-by: Emilien Bevierre <emilien.bevierre@couchbase.com>
Signed-off-by: Emilien Bevierre <emilien.bevierre@couchbase.com>
Signed-off-by: Emilien Bevierre <emilien.bevierre@couchbase.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Emilien Bevierre <44171454+emilienbev@users.noreply.github.com>
Signed-off-by: Emilien Bevierre <emilien.bevierre@couchbase.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 29 out of 29 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import java.util.Arrays; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
| import java.util.Map; |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Emilien Bevierre <44171454+emilienbev@users.noreply.github.com>
… tests. Minor cleanup. Signed-off-by: Emilien Bevierre <emilien.bevierre@couchbase.com>
…in findBySearch - all() now applies a default limit of 10,000 when none is set; the FTS service default of 10 hits silently truncated results. - User-supplied SearchOptions are no longer mutated per subscription (sorts accumulated on retry/resubscribe and fluent siblings shared state); combining withOptions() with the individual with* methods now throws IllegalArgumentException. - count()/exists() drain rows before reading the metadata trailer (the SDK only completes metaData() once rows are consumed) and request limit 0 when options are owned by the template. - Stale-hit skip logging now fires on actual KV misses (findById maps DocumentNotFoundException to empty, so the previous onErrorResume was dead code); hydration uses flatMapSequential instead of sequential concatMap. - Blocking count() throws CouchbaseQueryExecutionException instead of NPE on a null count. - @Search combined with @query on one method now throws instead of silently preferring @Search. Signed-off-by: Emilien Bevierre <emilien.bevierre@couchbase.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2085
Adds:
findBySearchto both standard and reactive templates, with builder for configuring index names, limits, sorting, facets, etc.@Searchfor query strings and@SearchIndexto specify index names.SearchResult<T>wrapper to provide access to entities, metadata, and facets. Supports standard terminal operations like all(), first(), and count().@ScanConsistencyand enabled Page/Slice for the non-reactive repository.