developmentOnly and testAndDevelopmentOnly configurations do not specify any attributes causing resolution problems - #51493
Open
wakingrufus wants to merge 1 commit into
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
wakingrufus
force-pushed
the
fix-configuration-attributes
branch
from
August 28, 2026 20:39
820e2f8 to
6a432fc
Compare
wakingrufus
marked this pull request as ready for review
August 28, 2026 20:39
wilkinsona
requested changes
Sep 2, 2026
| * @param from configuration from which to copy attributes | ||
| * @param to configuration to which attributes will be copied | ||
| */ | ||
| @SuppressWarnings({ "rawtypes", "unchecked", "NullAway" }) |
Member
There was a problem hiding this comment.
NullAway warnings should not be suppressed
Author
There was a problem hiding this comment.
in this case, the key is already verified to be present, so it is null safe code, but nullaway is not able to tell. I am not sure how else to handle this situation
Author
There was a problem hiding this comment.
in my latest refactor, it is clear that only the legacy implementation requires this supression, if that helps
wilkinsona
added
the
status: waiting-for-feedback
wakingrufus
force-pushed
the
fix-configuration-attributes
branch
2 times, most recently
from
September 2, 2026 14:52
33584ad to
6e20db6
Compare
Author
|
Thanks for the review! I have updated this PR with the feedback. |
spring-projects-issues
added
status: feedback-provided
wakingrufus
force-pushed
the
fix-configuration-attributes
branch
6 times, most recently
from
September 2, 2026 15:11
908d338 to
a9d7ba5
Compare
…y and testAndDevelopmentOnly fixes spring-projectsgh-51492 include refactors in the modified code to better comply with Gradle lazy APIs Signed-off-by: John Burns <wakingrufus@gmail.com>
wakingrufus
force-pushed
the
fix-configuration-attributes
branch
from
September 2, 2026 15:12
a9d7ba5 to
4e024fb
Compare
wilkinsona
changed the title
wilkinsona
added
type: bug
wilkinsona
requested changes
Sep 2, 2026
wilkinsona
left a comment
wilkinsona
left a comment
Member
There was a problem hiding this comment.
Thanks for the updates. The change is still a little too broad as it tackles three separate things:
- Copying attributes onto the
developmentOnlyandtestDevelopmentOnlyconfigurations - Introducing some laziness when working with configurations (using
namedinstead ofgetByName - Marking some configurations as not being consumable
There are also some places where a method has changed from private to static that appear unnecessary.
I'd like this PR to focus solely on 1. 2 and 3 are changes that should probably be made but they need to be considered and applied separately. They may also be broader in scope than tackled here as, for example, there are several other places where we call ConfigurationContainer.getByName(String) that may also be candidates for being lazy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copy configuration attributes from runtimeClasspath to developmentOnly and testAndDevelopmentOnly
fixes gh-51492
the developmentOnly and testAndDevelopmentOnly do not specify attributes, which can lead to Gradle selecting the wrong variant, or failing to resolve due to an ambiguity error. This can be avoided by following best practices regarding configuration attributes in gradle:
https://docs.gradle.org/current/userguide/best_practices_dependencies.html#use_attributes_on_configurations
the productionRuntimeClasspath was previously fixed in b01235e so a similar fix is needed for these configurations as well
I also included refactors in the modified code to better comply with Gradle lazy APIs