fix: allow empty typed slice flag values#485
Closed
happysnaker wants to merge 1 commit into
Closed
Conversation
Author
|
Maintainer context for review:
|
Collaborator
|
Same as #486. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IntSlice,Int32Slice,Int64Slice,UintSlice,Float32Slice,Float64Slice, andDurationSlice--flag=now produces a non-nil empty slice while leaving default values unchanged when the flag is omittedContext
StringSlicealready treats--flag=as an empty slice, but the typed slice implementations still fed the empty string throughstrings.Split, which turns it into[]string{""}and then fails during numeric / duration parsing.This change uses the same empty-input interpretation consistently for the typed slice variants, matching the expectation discussed in #222.
Notes
UintSlicekeeps the existing base-autodetection behavior from fix: allow hex input in UintSlice #484 while sharing the same empty-input helperCloses #222