fix(queries): preserve sort in exported CSVs, again - #8394
Conversation
Co-Authored-By: eos Shapland <149845916+g1rly-c0d3r@users.noreply.github.com>
|
Warning One or more dependencies are approaching or past End-of-Life. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesCSV Export Ordering
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
g1rly-c0d3r
left a comment
There was a problem hiding this comment.
Testing instructions
- Verify that the exported CSV is sorted by the same column as in the query.
- Sort by multiple columns and ensure the left-most column is sorted first
Hey I know this one.
rijulpoudel
left a comment
There was a problem hiding this comment.
- Verify that the exported CSV is sorted by the same column as in the query.
- Note that any other column may not be sorted if the column you sorted by has duplicates (i.e. two agents with the first name "A")
- Sort by multiple columns and ensure the left-most column is sorted first
- after that, it should sort by the next column to the right, and so on
Test successful. The sortings are respected in the exported CSV.
emenslin
left a comment
There was a problem hiding this comment.
- Verify that the exported CSV is sorted by the same column as in the query.
- Sort by multiple columns and ensure the left-most column is sorted first
Looks good, sorting is respected!
Fixes #5038
This PR adds back the CSV export tool preserving the sort order of a query. This was lost when #7994 was merged into
maina few days ago.Summary by CodeRabbit