Bring changes from `v7.12.0.7` to `main` by melton-jason · Pull Request #8378 · specify/specify7

melton-jason · 2026-07-29T15:15:51Z

Checklist

Self-review the PR after opening it to make sure the changes look good and
self-explanatory (or properly documented)
Add relevant issue to release milestone
Add pr to documentation list
Add automated tests
Add a reverse migration if a migration is present in the PR
Add migration function to

specify7/specifyweb/specify/management/commands/run_key_migration_functions.py

Line 50 in ea04665

def fix_schema_config(stdout: WriteToStdOut | None = None):

Testing instructions

These steps are taken from the v7.12.0.7 testing checklist, with the step for #8181 ommitted as

Ensure the testing instructions succeed from fix(trees): replace child/synonym LEFT JOINs with scalar subqueries #8243
Ensure the testing instructions succeed from Missing reverse relationships in datamodel.py for new *Attachment models #8181
- At the time of writing, the attachment relationships should be disabled

Creating a new Database using Guided Setup

Discipline Verification Steps (These are referred to in the below General Testing Instructions)

Verify all trees are present and populated with the correct data
Generally ensure entries in the Schema Config are correct
- Make sure Tables and Fields have sensible default labels and descriptions
- Ensure that fields and tables
Verify picklists are created in each Collection and have the correct values
Verify picklists that should be associated with a field are correctly associated (some examples of relationships are provided below)
- Preparation -> prepType
- Discipline -> type
- CollectionObjectGroup -> cogType
Ensure Schema Configuration changes are persistent
- Make changes to the Discipline's schema in the Schema Config (editing the label/description of tables and fields, modifying a table or field's visibility, changing a field's picklist, etc.)
- Completely stop the Specify instance
- Restart the Specify instance
  - On the Test Panel, the above can be accomplished by Removing an instance from the test panel (do not delete/remove the database!) and re-adding the instance to force a restart
- Ensure the modifications you made are persistent and still present
Ensure Tree Configuration changes are persistent
- Rename, add, and/or remove one or more ranks to one or more Trees
- Completely stop the Specify instance
- Restart the Specify instance
- Ensure the tree configuration changes are persistent and still present

General Testing Instructions

Using Guided Setup, create a Specify instance with any non-geology (i.e., biology) discipline and populate trees with defaults
Ensure the Discipline passes the above Discipline Verification Steps
Using Guided Setup, create a Specify instance with a Geology discipline and populate trees with default values
Ensure the Discipline passes the above Discipline Verification Steps
Create a new non-geology Discipline and Collection to an existing Specify instance through the System Config tool
Ensure the Discipline passes the above Discipline Verification Steps
Create a new geology Discipline and Collection to an existing Specify instance through the System Config tool
Ensure the Discipline passes the above Discipline Verification Steps
Verify the new Chronostrat defaults are populated correctly
Verify the new IUGS ICC chart shows up (the chart has a 2026 in the top right of the image)

…ds for tables

melton-jason · 2026-07-29T15:34:56Z

@coderabbitai review --dir ./specifyweb/specify

coderabbitai · 2026-07-29T15:35:07Z

@melton-jason: Reviewing the committed changes in specifyweb/specify, with attention to migration safety and compatibility.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

I think ideally we should a take more black-box focused approach to testing. That is: test the result or output of the functions (or any composition/aggregation of functions, such as the complete run_key_migrations suite) rather than implementation specifics such as which functions get called in which order. Ultimately, it's the result that matters here and I think these tests that worry about the implementation might lead to more harm than good (e.g., everytime the implementation or "wrapper" for the functionality changes then the tests have to be changed). Also see #8225 (review)

g1rly-c0d3r

Testing instructions

These steps are taken from the v7.12.0.7 testing checklist, with the step for #8181 ommitted as

Ensure the testing instructions succeed from #8243
Ensure the testing instructions succeed from #8181
- At the time of writing, the attachment relationships should be disabled

Creating a new Database using Guided Setup

Discipline Verification Steps (These are referred to in the below General Testing Instructions)

Verify all trees are present and populated with the correct data
Generally ensure entries in the Schema Config are correct
- Make sure Tables and Fields have sensible default labels and descriptions
- Ensure that fields and tables
Verify picklists are created in each Collection and have the correct values
Verify picklists that should be associated with a field are correctly associated (some examples of relationships are provided below)
- Preparation -> prepType
- Discipline -> type
- CollectionObjectGroup -> cogType
Ensure Schema Configuration changes are persistent
- Make changes to the Discipline's schema in the Schema Config (editing the label/description of tables and fields, modifying a table or field's visibility, changing a field's picklist, etc.)
- Completely stop the Specify instance
- Restart the Specify instance
  - On the Test Panel, the above can be accomplished by Removing an instance from the test panel (do not delete/remove the database!) and re-adding the instance to force a restart
- Ensure the modifications you made are persistent and still present
Ensure Tree Configuration changes are persistent
- Rename, add, and/or remove one or more ranks to one or more Trees
- Completely stop the Specify instance
- Restart the Specify instance
- Ensure the tree configuration changes are persistent and still present

General Testing Instructions

Using Guided Setup, create a Specify instance with any non-geology (i.e., biology) discipline and populate trees with defaults
Ensure the Discipline passes the above Discipline Verification Steps
Using Guided Setup, create a Specify instance with a Geology discipline and populate trees with default values
Ensure the Discipline passes the above Discipline Verification Steps
Create a new non-geology Discipline and Collection to an existing Specify instance through the System Config tool
Ensure the Discipline passes the above Discipline Verification Steps
Create a new geology Discipline and Collection to an existing Specify instance through the System Config tool
Ensure the Discipline passes the above Discipline Verification Steps
Verify the new Chronostrat defaults are populated correctly
Verify the new IUGS ICC chart shows up (the chart has a 2026 in the top right of the image)

Looks good! Nothing I tested was different from last time.

rijulpoudel

Testing instructions

Ensure the testing instructions succeed from #8243
Ensure the testing instructions succeed from #8181
- At the time of writing, the attachment relationships should be disabled

Creating a new Database using Guided Setup

Discipline Verification Steps (These are referred to in the below General Testing Instructions)

Verify all trees are present and populated with the correct data
Generally ensure entries in the Schema Config are correct
- Make sure Tables and Fields have sensible default labels and descriptions
- Ensure that fields and tables
Verify picklists are created in each Collection and have the correct values
Verify picklists that should be associated with a field are correctly associated (some examples of relationships are provided below)
- Preparation -> prepType
- Discipline -> type
- CollectionObjectGroup -> cogType
Ensure Schema Configuration changes are persistent
- Make changes to the Discipline's schema in the Schema Config (editing the label/description of tables and fields, modifying a table or field's visibility, changing a field's picklist, etc.)
- Completely stop the Specify instance
- Restart the Specify instance
  - On the Test Panel, the above can be accomplished by Removing an instance from the test panel (do not delete/remove the database!) and re-adding the instance to force a restart
- Ensure the modifications you made are persistent and still present
Ensure Tree Configuration changes are persistent
- Rename, add, and/or remove one or more ranks to one or more Trees
- Completely stop the Specify instance
- Restart the Specify instance
- Ensure the tree configuration changes are persistent and still present

General Testing Instructions

Using Guided Setup, create a Specify instance with any non-geology (i.e., biology) discipline and populate trees with defaults
Ensure the Discipline passes the above Discipline Verification Steps
Using Guided Setup, create a Specify instance with a Geology discipline and populate trees with default values
Ensure the Discipline passes the above Discipline Verification Steps
Create a new non-geology Discipline and Collection to an existing Specify instance through the System Config tool
Ensure the Discipline passes the above Discipline Verification Steps
Create a new geology Discipline and Collection to an existing Specify instance through the System Config tool
Ensure the Discipline passes the above Discipline Verification Steps
Verify the new Chronostrat defaults are populated correctly
Verify the new IUGS ICC chart shows up (the chart has a 2026 in the top right of the image)

Everything passed. I was able to recreate everything like we did the last time.

Triggered by 6db0903 on branch refs/heads/issue-8302

feat(attachments): add "match by mapping file" support

CarolineDenis and others added 30 commits June 18, 2026 15:24

fix: add tests for run key migration

4ad3ce5

fix: remove unused file/definition

4a208b1

fix: Clear cached schema override state between tests

053b06c

fix: Assert call

ffdf85f

fix: Revert run_key_migration chnages

d7161ec

fix: imports and performance for 0004 migration

0be0c12

chore: add bug comment for irrevirsible migration

34aaccb

Merge remote-tracking branch 'origin/issue-8058' into issue-8224

c3cf4d7

Add second test file for run_key_migration_functions

faae90d

Add test suite for select series migration helper 0031

8d8622c

Test: Update test_run_key_migration_functions_2

e8f1eb7

Fix: Add decorator

4409b79

Fix: Import ApiTest

b6a523e

Test: Add tests for helper_0039

a831e7e

Refactor: Remove unecessary agent-loan-gift test

1e95d61

Refactor: Move dedup logic to deduplication file

72eaaff

Test: Add a new test suite for run key migration indepotency

ba79e48

Fix: Update cots_tests.py

8dbe71b

Fix: Align expected migration function names

06e8f30

Fix: assertion

f7bb933

Fix: fix keeper logic

ec885eb

Fix: Change tectonic class

88d3588

Fix: Adjust bulk-create assertions

9d48f36

chore: reformat helper functions

8093c2a

chore: correct migration helper names for clarity

601c0d6

fix: create SpLocaleItemStr records when creating Schema Config recor…

0399624

…ds for tables

Fix: Renaming wrong migration helper title

59f0ecb

Fix: Renaming wrong migration helper title import

be044b4

Test: Add test suite for migration helper 0007

8202bc1

Test: Add test suite for migration helper 0017

42b37a9

specify deleted a comment from coderabbitai Bot Jul 29, 2026

melton-jason added 3 commits July 29, 2026 10:46

fix: errors in delete blocker tests

80d69cd

fix(tests): stop preserving discipline dirs of the same timestamp

cb5bf0a

melton-jason marked this pull request as ready for review July 29, 2026 19:59

melton-jason requested review from a team, emenslin and g1rly-c0d3r July 29, 2026 20:00

melton-jason changed the title ~~Merge v7.12.0.7 into main~~ Bring changes from v7.12.0.7 to main Jul 29, 2026

g1rly-c0d3r approved these changes Jul 29, 2026

View reviewed changes

CarolineDenis approved these changes Jul 30, 2026

View reviewed changes

Merge branch 'main' into issue-8302

dade764

rijulpoudel self-requested a review July 30, 2026 14:54

rijulpoudel approved these changes Jul 30, 2026

View reviewed changes

grantfitzsimmons added 10 commits July 30, 2026 13:04

feat(datamodel): add schema for matchingmode

fb334d8

feat(attachments): add support for FNP

9beaa43

feat(attachments): add support for FNP by description

935cbb3

feat(attachments): add support for FN and Disposal

d22e16d

Merge branch 'v7_12_0_7_main' into issue-8302

6db0903

Lint code with ESLint and Prettier

b926cf2

Triggered by 6db0903 on branch refs/heads/issue-8302

fix(migrations): use the new system for captions

3452517

feat(attachments): add warning dialog for missing items

28ad912

Merge pull request #8311 from specify/issue-8302

f363164

feat(attachments): add "match by mapping file" support

Merge branch 'main' into v7_12_0_7_main

9cfe7e7

grantfitzsimmons merged commit b5a897d into main Aug 2, 2026
24 checks passed

github-project-automation Bot moved this from 📋Back Log to ✅Done in General Tester Board Aug 2, 2026

grantfitzsimmons deleted the v7_12_0_7_main branch August 2, 2026 02:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bring changes from `v7.12.0.7` to `main` - #8378

Bring changes from `v7.12.0.7` to `main`#8378
grantfitzsimmons merged 427 commits into
mainfrom
v7_12_0_7_main

melton-jason commented Jul 29, 2026 •

edited

Loading

Uh oh!

melton-jason commented Jul 29, 2026

Uh oh!

coderabbitai Bot commented Jul 29, 2026 •

edited

Loading

Uh oh!

g1rly-c0d3r left a comment

Uh oh!

rijulpoudel left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

melton-jason commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Testing instructions

Uh oh!

melton-jason commented Jul 29, 2026

Uh oh!

coderabbitai Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

g1rly-c0d3r left a comment

Choose a reason for hiding this comment

Testing instructions

Uh oh!

rijulpoudel left a comment

Choose a reason for hiding this comment

Testing instructions

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

melton-jason commented Jul 29, 2026 •

edited

Loading

coderabbitai Bot commented Jul 29, 2026 •

edited

Loading