-
Notifications
You must be signed in to change notification settings - Fork 4
Hip wrapper #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Hip wrapper #20
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
25856ec
init changes from spack-packages/4411
scheibelp 080bdfb
dispatch hipcc to SPACK_HIPCXX
scheibelp 2b8ef4e
names that cmake won't reject
scheibelp d6cc6b2
amdhip identifier not used; language was swapped with vdep
scheibelp ed41d0c
handle hipflags (requires update in spack core to be useful, but does…
scheibelp a686054
fix vdep
scheibelp 6f5e2e4
-x doesnt mean language for ld
scheibelp da7be1a
test processing of -x and SPACK_HIPCXX dispatch based on -x and argv0…
scheibelp ce78199
expand SPACK_xFLAGS test for hipflags
scheibelp ba2491d
fold mode determination from flags for spackhip into existing test_modes
scheibelp 2c165b1
test routing of -x/spackhip to SPACK_HIPCXX
scheibelp a0f82a8
update no-dash-x processing for ld test
scheibelp efb910d
rm redundant check
scheibelp dfd1d74
another redundant test
scheibelp 44e2dec
bad test reference
scheibelp d8eafe4
style
scheibelp af20c05
apply suggested commit from review (fix bug where -x messed with cpp;…
scheibelp 9746dac
Add recommended tests verbatim to start
scheibelp 163437c
test_x_ignored_for_ld is covered by test_x_is_not_a_language_for_ld,
scheibelp df7cf47
rm -x case in test_hip_command_routing covered by test_x_language_spe…
scheibelp d8af366
add comments about additional cases being covered
scheibelp da0d5ee
add test comment
scheibelp ba4e07d
move helper definition
scheibelp ecd8480
rename test
scheibelp 3e2f803
rm reference to SPACK_ALWAYS_HIPCXXFLAGS
scheibelp 4a18021
fix test reference error; add check for catching bad test references
scheibelp 6bf779c
refactor test to use expect_command (was redoing work handled by that)
scheibelp 42d2524
replace another custom test with expect_command
scheibelp e7aff18
consolidate individual expect_contains/expect_command checks into sin…
scheibelp f433c68
more-stringent arg order checking w/ expect_args
scheibelp 1c07624
replace explicit continue w/ comment (appears to match other logic be…
scheibelp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.