Skip to content

Store origin URL for MCP in mcp.metapack#904

Merged
jviotti merged 2 commits into
mainfrom
origin-mcp
May 14, 2026
Merged

Store origin URL for MCP in mcp.metapack#904
jviotti merged 2 commits into
mainfrom
origin-mcp

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented May 14, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 20 files

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 14, 2026

🤖 Augment PR Summary

Summary: This PR moves the MCP “allowed origin” source from metadata.json into explorer/%/mcp.metapack, so MCP responses can derive CORS settings from MCP-specific metadata.

Changes:

  • Dropped the origin parameter/state from Action/ActionDispatcher and updated all action constructors accordingly
  • Enterprise MCP handler now reads origin from mcp.metapack and stores it as an owning std::string
  • OSS MCP action likewise reads origin from mcp.metapack and uses it for CORS headers
  • Generator now writes origin into the MCP metapack document and removes it from metadata.json
  • Updated server startup to only read url from metadata.json
  • Adjusted CLI/unit tests to reflect the new metadata.json shape

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread src/actions/action_mcp_v1.h
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: dc6d202 Previous: 3cbc9c9 Ratio
Add one schema (0 existing) 237 ms 195 ms 1.22
Add one schema (100 existing) 25 ms 19 ms 1.32
Add one schema (1000 existing) 82 ms 58 ms 1.41
Add one schema (10000 existing) 931 ms 510 ms 1.83
Update one schema (1 existing) 17 ms 13 ms 1.31
Update one schema (101 existing) 25 ms 18 ms 1.39
Update one schema (1001 existing) 84 ms 60 ms 1.40
Update one schema (10001 existing) 732 ms 507 ms 1.44
Cached rebuild (1 existing) 5 ms 3 ms 1.67
Cached rebuild (101 existing) 8 ms 4 ms 2
Cached rebuild (1001 existing) 30 ms 16 ms 1.88
Cached rebuild (10001 existing) 304 ms 154 ms 1.97
Index 100 schemas 110 ms 82 ms 1.34
Index 1000 schemas 850 ms 662 ms 1.28
Index 10000 schemas 13238 ms 9852 ms 1.34

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: dc6d202 Previous: 3cbc9c9 Ratio
Add one schema (0 existing) 240 ms 231 ms 1.04
Add one schema (100 existing) 28 ms 29 ms 0.97
Add one schema (1000 existing) 83 ms 87 ms 0.95
Add one schema (10000 existing) 683 ms 950 ms 0.72
Update one schema (1 existing) 22 ms 21 ms 1.05
Update one schema (101 existing) 28 ms 28 ms 1
Update one schema (1001 existing) 83 ms 87 ms 0.95
Update one schema (10001 existing) 695 ms 713 ms 0.97
Cached rebuild (1 existing) 7 ms 7 ms 1
Cached rebuild (101 existing) 9 ms 10 ms 0.90
Cached rebuild (1001 existing) 31 ms 32 ms 0.97
Cached rebuild (10001 existing) 275 ms 285 ms 0.96
Index 100 schemas 115 ms 116 ms 0.99
Index 1000 schemas 1002 ms 973 ms 1.03
Index 10000 schemas 14503 ms 13359 ms 1.09

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 5e140c6 into main May 14, 2026
5 checks passed
@jviotti jviotti deleted the origin-mcp branch May 14, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant