Loudly reject JSONL on fmt and lint --fix

[jviotti]

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

[augmentcode]

🤖 Augment PR Summary

Summary: This PR adds explicit multi-document input handling to CLI input parsing.

Changes:

• Recognizes JSONL and YAML multi-document streams from files, directories, and standard input.
• Emits individual InputJSON entries with document indexes and multi-document metadata.
• Preserves YAML position tracking across document boundaries.
• Rejects multi-document input for fmt and lint --fix with a dedicated error type.
• Adds centralized exception rendering and the unsupported-operation exit code for that error.
• Refactors file handling into a shared helper to cover direct files and directory traversal consistently.
• Adds CLI coverage for JSONL, YAML streams, stdin, directory inputs, and structured error output.

Technical Notes: Regular linting and validation can process each document independently, while rewrite-oriented commands reject ambiguous multi-document sources.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

[augmentcode]

src/input.h:175: std::isspace accepts characters such as form-feed and vertical-tab that JSON does not define as whitespace. Consequently, stdin containing a valid JSON value followed only by \f is accepted as a single JSON document here, whereas the JSON/JSONL parsers correctly reject that trailing byte.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[augmentcode]

src/input.h:307: A valid YAML stream whose first document is also valid JSON but has no initial --- is routed here instead of to the YAML parser; for example, {"foo": "first"}\n---\nfoo: second is valid multi-document YAML but JSONL rejects the --- line. This makes the new stdin multi-document YAML support depend on an optional first-document marker.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[cubic-dev-ai]

1 issue found across 16 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/input.h">

<violation number="1" location="src/input.h:280">
P1: This fallback classifies newline-delimited JSON on stdin as YAML before JSONL gets a chance to parse it. Move the JSONL attempt before the YAML fallback so `lint --fix` rejects JSONL as multiple documents and downstream commands retain the correct input type.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P1: This fallback classifies newline-delimited JSON on stdin as YAML before JSONL gets a chance to parse it. Move the JSONL attempt before the YAML fallback so lint --fix rejects JSONL as multiple documents and downstream commands retain the correct input type.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/input.h, line 280:

<comment>This fallback classifies newline-delimited JSON on stdin as YAML before JSONL gets a chance to parse it. Move the JSONL attempt before the YAML fallback so `lint --fix` rejects JSONL as multiple documents and downstream commands retain the correct input type.</comment>

<file context>
@@ -204,38 +258,199 @@ inline auto read_file(const std::filesystem::path &path) -> ParsedJSON {
-              .positions = std::move(positions),
-              .property_storage = std::move(property_storage),
-              .yaml = true};
+      documents = read_yaml_documents(yaml_stream);
     } catch (...) {
       throw sourcemeta::core::JSONFileParseError(stdin_path(), json_error);
</file context>

[cubic-dev-ai]

All reported issues were addressed across 7 files (changes from recent commits).

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>