fix: build folder path from Backend.Path and silence null-revision bindings in revision file tree - #2595
Merged
love-linger merged 1 commit intoJul 31, 2026
Conversation
…ndings in revision file tree
- RevisionFileTreeView.SetSearchResultAsync: concatenate Backend.Path
instead of stringifying the Backend Object, whose default ToString()
leaked "SourceGit.Models.Object/" into child node paths and corrupted
the DirHistories window title.
- RevisionFiles / Blame: add FallbackValue={x:Null} to Commit.SHA /
Revision.SHA. These commits are loaded asynchronously and are null
when the view first binds, which logged "Value is null" binding errors.
love-linger
added a commit
that referenced
this pull request
Jul 31, 2026
Use `ContentControl.DataTemplates` instead of `FallbackValue` when the child control does not need to access the parent's DataContext Signed-off-by: leo <longshuang@msn.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RevisionFileTreeView.SetSearchResultAsync: concatenate Backend.Path instead of stringifying the Backend Object, whose default ToString() leaked "SourceGit.Models.Object/" into child node paths and corrupted the DirHistories window title.
RevisionFiles / Blame: add FallbackValue={x:Null} to Commit.SHA / Revision.SHA. These commits are loaded asynchronously and are null when the view first binds, which logged "Value is null" binding errors.
Before:
