[ImgBot] Optimize images - #1
Open
imgbot[bot] wants to merge 1 commit into
Open
Conversation
*Total -- 5,039.68kb -> 3,788.11kb (24.83%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_rect_multiple_clips_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 14.76kb -> 1.52kb (89.73%) /engine/src/flutter/shell/platform/embedder/fixtures/external_texture_metal.png -- 3.18kb -> 0.34kb (89.36%) /engine/src/flutter/shell/platform/embedder/fixtures/compositor_root_surface_xformation.png -- 9.26kb -> 1.33kb (85.63%) /engine/src/flutter/shell/platform/embedder/fixtures/impeller_test.png -- 3.20kb -> 0.48kb (85%) /engine/src/flutter/shell/platform/embedder/fixtures/external_texture_impeller.png -- 3.20kb -> 0.57kb (82.03%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprect_after_moved_multiple_clips_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 16.52kb -> 3.30kb (80.02%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprect_multiple_clips_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 16.32kb -> 3.29kb (79.85%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_path_multiple_clips_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 18.22kb -> 3.71kb (79.61%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_clippath_multiple_clips_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 17.00kb -> 3.98kb (76.62%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_rect_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 18.74kb -> 4.70kb (74.93%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprrect_multiple_clips_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 18.53kb -> 4.69kb (74.67%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprect_after_moved_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 18.68kb -> 4.75kb (74.59%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprect_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 18.51kb -> 4.78kb (74.18%) /engine/src/flutter/shell/platform/embedder/fixtures/gradient_metal.png -- 44.36kb -> 12.82kb (71.11%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_bogus_font_text_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 23.52kb -> 6.93kb (70.55%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_spawn_engine_works_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 23.52kb -> 6.93kb (70.55%) /engine/src/flutter/shell/platform/embedder/fixtures/compositor_with_root_layer_only.png -- 1.37kb -> 0.41kb (70.09%) /engine/src/flutter/shell/platform/embedder/fixtures/compositor_platform_layer_with_no_overlay.png -- 2.31kb -> 0.73kb (68.6%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_opacity_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 23.91kb -> 8.11kb (66.09%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_clippath_with_transform_multiple_clips_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 17.94kb -> 6.38kb (64.44%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_multiple_background_foreground_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 31.49kb -> 11.26kb (64.23%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_darwin_system_font_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 31.59kb -> 11.33kb (64.15%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_transform_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 22.43kb -> 8.10kb (63.89%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprect_with_transform_multiple_clips_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 19.05kb -> 7.02kb (63.14%) /engine/src/flutter/lib/ui/fixtures/2_dispose_op_restore_previous.apng.69.png -- 22.81kb -> 8.45kb (62.96%) /engine/src/flutter/lib/ui/fixtures/impeller_2_dispose_op_restore_previous.apng.69.png -- 22.79kb -> 8.45kb (62.94%) /engine/src/flutter/lib/ui/fixtures/2_dispose_op_restore_previous.apng.67.png -- 22.62kb -> 8.42kb (62.77%) /engine/src/flutter/lib/ui/fixtures/impeller_2_dispose_op_restore_previous.apng.67.png -- 22.60kb -> 8.42kb (62.75%) /engine/src/flutter/lib/ui/fixtures/2_dispose_op_restore_previous.apng.68.png -- 22.58kb -> 8.41kb (62.74%) /engine/src/flutter/lib/ui/fixtures/impeller_2_dispose_op_restore_previous.apng.68.png -- 22.57kb -> 8.41kb (62.72%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprrect_with_transform_multiple_clips_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 20.14kb -> 7.75kb (61.55%) /engine/src/flutter/shell/platform/embedder/fixtures/compositor_with_platform_layer_on_bottom.png -- 1.42kb -> 0.55kb (61.02%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_clippath_with_transform_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 20.69kb -> 8.08kb (60.94%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprect_with_transform_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 21.80kb -> 8.68kb (60.2%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprrect_with_transform_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 21.48kb -> 8.58kb (60.07%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_large_cliprrect_with_transform_multiple_clips_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 23.79kb -> 9.57kb (59.78%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_large_cliprrect_with_transform_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 27.45kb -> 11.31kb (58.8%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprrect_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 19.92kb -> 8.33kb (58.15%) /engine/src/flutter/shell/platform/embedder/fixtures/scene_without_custom_compositor_with_xform.png -- 2.39kb -> 1.02kb (57.17%) /dev/tools/vitool/test_assets/empty_svg_2_100x50.svg -- 0.18kb -> 0.08kb (56.04%) /engine/src/flutter/shell/platform/embedder/fixtures/scene_without_custom_compositor.png -- 2.57kb -> 1.14kb (55.73%) /engine/src/flutter/shell/platform/embedder/fixtures/compositor_software.png -- 2.55kb -> 1.14kb (55.54%) /engine/src/flutter/shell/platform/embedder/fixtures/compositor.png -- 2.55kb -> 1.14kb (55.51%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_path_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 24.09kb -> 10.95kb (54.56%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_large_cliprrect_multiple_clips_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 21.89kb -> 9.98kb (54.4%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_clippath_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 21.32kb -> 9.83kb (53.9%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_with_negative_backdrop_filter_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 28.28kb -> 13.71kb (51.51%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_rotate_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 25.30kb -> 12.30kb (51.37%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 24.27kb -> 11.97kb (50.67%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_non_full_screen_flutter_view_platform_view_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 24.17kb -> 11.96kb (50.51%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_rrect_multiple_clips_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 27.39kb -> 13.76kb (49.77%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_large_cliprrect_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 25.58kb -> 12.86kb (49.73%) /engine/src/flutter/shell/platform/embedder/fixtures/dpr_xform.png -- 56.25kb -> 29.47kb (47.61%) /engine/src/flutter/shell/platform/embedder/fixtures/vk_gradient.png -- 69.55kb -> 37.59kb (45.95%) /engine/src/flutter/shell/platform/embedder/fixtures/gradient.png -- 69.55kb -> 37.59kb (45.95%) /engine/src/flutter/shell/platform/embedder/fixtures/gradient_xform.png -- 70.80kb -> 38.90kb (45.06%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_with_other_backdrop_filter_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 29.93kb -> 16.78kb (43.93%) /engine/src/flutter/shell/platform/embedder/fixtures/vk_dpr_noxform.png -- 61.96kb -> 35.42kb (42.83%) /engine/src/flutter/shell/platform/embedder/fixtures/dpr_noxform.png -- 61.97kb -> 35.43kb (42.82%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_multiple_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 33.53kb -> 19.22kb (42.67%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_rrect_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 34.87kb -> 20.08kb (42.41%) /engine/src/flutter/shell/platform/embedder/fixtures/arc_end_caps.png -- 5.87kb -> 3.40kb (42%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_views_with_other_backdrop_filter_impeller_iPhone SE (3rd generation)_26.2_simulator.png -- 44.16kb -> 26.23kb (40.59%) /engine/src/flutter/shell/platform/embedder/fixtures/verifyb143464703_soft_noxform.png -- 15.38kb -> 9.92kb (35.47%) /engine/src/flutter/shell/platform/embedder/fixtures/impeller_text_test.png -- 3.25kb -> 2.15kb (33.86%) /dev/integration_tests/flutter_gallery/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_512.png -- 14.45kb -> 9.69kb (32.93%) /dev/integration_tests/ui/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_512.png -- 14.45kb -> 9.69kb (32.93%) /examples/hello_world/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_512.png -- 14.45kb -> 9.69kb (32.93%) /dev/a11y_assessments/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_512.png -- 14.45kb -> 9.69kb (32.93%) /dev/manual_tests/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_512.png -- 14.45kb -> 9.69kb (32.93%) /examples/image_list/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_512.png -- 14.45kb -> 9.69kb (32.93%) /examples/api/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_512.png -- 14.45kb -> 9.69kb (32.93%) /examples/image_list/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_1024.png -- 45.89kb -> 31.58kb (31.18%) /dev/integration_tests/flutter_gallery/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_1024.png -- 45.89kb -> 31.58kb (31.18%) /dev/a11y_assessments/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_1024.png -- 45.89kb -> 31.58kb (31.18%) /dev/integration_tests/ui/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_1024.png -- 45.89kb -> 31.58kb (31.18%) /examples/api/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_1024.png -- 45.89kb -> 31.58kb (31.18%) /examples/hello_world/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_1024.png -- 45.89kb -> 31.58kb (31.18%) /dev/manual_tests/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_1024.png -- 45.89kb -> 31.58kb (31.18%) /engine/src/flutter/docs/rbe/luci.png -- 98.61kb -> 70.27kb (28.73%) /examples/image_list/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_16.png -- 1.40kb -> 1.00kb (28.62%) /dev/integration_tests/flutter_gallery/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_16.png -- 1.40kb -> 1.00kb (28.62%) /dev/integration_tests/ui/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_16.png -- 1.40kb -> 1.00kb (28.62%) /dev/a11y_assessments/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_16.png -- 1.40kb -> 1.00kb (28.62%) /examples/hello_world/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_16.png -- 1.40kb -> 1.00kb (28.62%) /dev/manual_tests/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_16.png -- 1.40kb -> 1.00kb (28.62%) /examples/api/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_16.png -- 1.40kb -> 1.00kb (28.62%) /dev/integration_tests/flutter_gallery/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_256.png -- 5.79kb -> 4.27kb (26.23%) /dev/a11y_assessments/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_256.png -- 5.79kb -> 4.27kb (26.23%) /dev/integration_tests/ui/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_256.png -- 5.79kb -> 4.27kb (26.23%) /examples/hello_world/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_256.png -- 5.79kb -> 4.27kb (26.23%) /examples/api/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_256.png -- 5.79kb -> 4.27kb (26.23%) /dev/manual_tests/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_256.png -- 5.79kb -> 4.27kb (26.23%) /examples/image_list/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_256.png -- 5.79kb -> 4.27kb (26.23%) /engine/src/flutter/lib/ui/fixtures/DashInNooglerHat%20WithSpace.jpg -- 346.37kb -> 257.43kb (25.68%) /engine/src/flutter/lib/ui/fixtures/DashInNooglerHat.jpg -- 346.37kb -> 257.43kb (25.68%) /engine/src/flutter/shell/platform/embedder/fixtures/verifyb143464703.png -- 9.24kb -> 6.89kb (25.48%) /engine/src/flutter/lib/web_ui/test/ui/image/sample_image1.png -- 14.40kb -> 10.83kb (24.76%) /dev/integration_tests/flutter_gallery/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_128.png -- 3.20kb -> 2.60kb (18.77%) /dev/integration_tests/ui/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_128.png -- 3.20kb -> 2.60kb (18.77%) /examples/hello_world/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_128.png -- 3.20kb -> 2.60kb (18.77%) /dev/a11y_assessments/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_128.png -- 3.20kb -> 2.60kb (18.77%) /examples/api/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_128.png -- 3.20kb -> 2.60kb (18.77%) /dev/manual_tests/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_128.png -- 3.20kb -> 2.60kb (18.77%) /examples/image_list/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_128.png -- 3.20kb -> 2.60kb (18.77%) /engine/src/flutter/docs/flutter_logo.png -- 4.16kb -> 3.53kb (15.18%) /dev/tools/vitool/test_assets/illegal_svg_multiple_roots.svg -- 0.10kb -> 0.09kb (12.87%) /dev/tools/vitool/test_assets/empty_svg_1_48x48.svg -- 0.09kb -> 0.08kb (12.77%) /dev/tools/vitool/test_assets/bar_group_opacity.svg -- 0.22kb -> 0.20kb (11.01%) /dev/tools/vitool/test_assets/bars_group.svg -- 0.30kb -> 0.26kb (10.86%) /engine/src/flutter/lib/ui/fixtures/Horizontal.jpg -- 11.08kb -> 9.90kb (10.6%) /dev/tools/vitool/test_assets/bar_group_scale.svg -- 0.23kb -> 0.21kb (9.62%) /dev/tools/vitool/test_assets/bar_group_translate.svg -- 0.24kb -> 0.21kb (9.5%) /dev/tools/vitool/test_assets/leading_space_path_command.svg -- 0.13kb -> 0.12kb (9.49%) /dev/tools/vitool/test_assets/illegal_transform.svg -- 0.24kb -> 0.22kb (9.39%) /engine/src/flutter/lib/ui/fixtures/DisplayP3Logo.jpg -- 4.77kb -> 4.33kb (9.19%) /dev/tools/vitool/test_assets/bar_group_rotate_scale.svg -- 0.25kb -> 0.23kb (8.98%) /dev/tools/vitool/test_assets/illegal_path.svg -- 0.14kb -> 0.13kb (8.33%) /engine/src/flutter/lib/ui/fixtures/four_frame_with_reuse_end.png -- 0.50kb -> 0.46kb (7.78%) /engine/src/flutter/lib/ui/fixtures/DisplayP3Logo.png -- 2.95kb -> 2.73kb (7.44%) /dev/tools/vitool/test_assets/horizontal_bar.svg -- 0.18kb -> 0.17kb (7.14%) /dev/tools/vitool/test_assets/horizontal_bar_relative.svg -- 0.18kb -> 0.17kb (7.1%) /dev/tools/vitool/test_assets/close_path_in_middle.svg -- 0.19kb -> 0.18kb (6.6%) /engine/src/flutter/lib/ui/fixtures/four_frame_with_reuse.gif -- 1.95kb -> 1.84kb (5.46%) /engine/src/flutter/lib/ui/fixtures/impeller_four_frame_with_reuse_end.png -- 0.49kb -> 0.46kb (5.39%) /engine/src/flutter/impeller/fixtures/monkey.png -- 603.17kb -> 572.78kb (5.04%) /engine/src/flutter/testing/resources/performance_overlay_gold_60fps.png -- 15.74kb -> 15.02kb (4.56%) /engine/src/flutter/shell/common/fixtures/hello_loop_2.gif -- 28.64kb -> 27.36kb (4.46%) /engine/src/flutter/lib/ui/fixtures/hello_loop_2.gif -- 28.64kb -> 27.36kb (4.46%) /engine/src/flutter/impeller/fixtures/blend_mode_src.png -- 33.71kb -> 32.51kb (3.55%) /engine/src/flutter/testing/resources/performance_overlay_gold_90fps.png -- 15.82kb -> 15.28kb (3.43%) /engine/src/flutter/testing/resources/performance_overlay_gold_120fps.png -- 15.70kb -> 15.18kb (3.36%) /engine/src/flutter/testing/skia_gold_client/tool/e2e_fixtures/solid_blue_square.png -- 2.35kb -> 2.29kb (2.49%) /engine/src/flutter/testing/skia_gold_client/tool/e2e_fixtures/solid_red_square.png -- 2.67kb -> 2.61kb (2.34%) /engine/src/flutter/lib/ui/fixtures/heart_end.png -- 38.64kb -> 37.80kb (2.17%) /engine/src/flutter/lib/ui/fixtures/impeller_heart_end.png -- 38.63kb -> 37.80kb (2.14%) /engine/src/flutter/testing/skia_gold_client/tool/e2e_fixtures/solid_green_square.png -- 3.48kb -> 3.41kb (1.8%) /engine/src/flutter/lib/ui/fixtures/Horizontal.png -- 24.98kb -> 24.63kb (1.37%) /engine/src/flutter/shell/common/fixtures/shelltest_screenshot.png -- 0.31kb -> 0.31kb (0.63%) /docs/engine/dart_split_aot_compilation.svg -- 107.78kb -> 107.31kb (0.43%) /engine/src/flutter/impeller/fixtures/blend_mode_dst.png -- 170.59kb -> 170.13kb (0.27%) /docs/engine/deferred_components_architecture.svg -- 298.78kb -> 297.96kb (0.27%) /docs/engine/deferred_components_call_lifecycle.svg -- 251.94kb -> 251.49kb (0.18%) /docs/engine/flutter_overview.svg -- 185.94kb -> 185.80kb (0.08%) /engine/src/flutter/impeller/fixtures/kalimba.jpg -- 66.47kb -> 66.46kb (0.01%) /examples/image_list/images/coast.jpg -- 197.60kb -> 197.60kb (0%) /engine/src/flutter/impeller/fixtures/airplane.jpg -- 69.71kb -> 69.71kb (0%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
addstone
pushed a commit
that referenced
this pull request
Jul 20, 2026
This patch: 1. Updates the `-mios-simulator-version-min` ldflag to `15.0` (this fixes the crash during test discovery). 2. refactors swiftc.py a bit, moves the target triplet logic from darwin/BUILD.gn to swiftc.py so you can override the ios version in a test target (but it's not absolutely necessary for this change since it's the linker flag that makes the difference). 3. Migrates a few xctest tests to swift testing tests. The names of the tests are kept as-is so the diff is easier to read. ### The Crash ``` (lldb) bt * thread flutter#9, name = '[Swift Testing] test discovery - loading test #0 (Task 3)', queue = 'com.apple.root.user-initiated-qos.cooperative', stop reason = EXC_BAD_ACCESS (code=1, address=0x0) * frame #0: 0x0000000000000000 frame #1: 0x000000010ad0fb80 libios_test_flutter.dylib`closure #1() in variable initialization expression of static AccessibilityFeaturesTests.$s22ios_test_flutter_swift26AccessibilityFeaturesTestsV43accessibilityFeatureFlagRawValuesAreCorrect4TestfMp_24accessorc8120add5c86a9e3fMu_ at @__swiftmacro_22ios_test_flutter_swift26AccessibilityFeaturesTestsV43accessibilityFeatureFlagRawValuesAreCorrect4TestfMp_.swift:0 frame flutter#2: 0x000000010224a39c Testing`partial apply for closure #1 in __checkClosureCall(performing:throws:mismatchExplanation:expression:comments:isRequired:sourceLocation:) frame flutter#3: 0x000000010224a39c Testing`partial apply for closure #1 in __checkClosureCall(performing:throws:mismatchExplanation:expression:comments:isRequired:sourceLocation:) frame flutter#4: 0x00000001022d8de8 Testing`(1) await resume partial function for generic specialization <(Testing.Test, Testing.Runner.Plan.Action)> of reabstraction thunk helper <τ_0_0 where τ_0_0: Swift.Sendable> from @escaping @isolated(any) @callee_guaranteed @async () -> (@out τ_0_0) to @escaping @callee_guaranteed @async () -> (@out τ_0_0, @error @owned Swift.Error) frame flutter#5: 0x000000010224ae24 Testing`closure #1 in __checkClosureCall(throws:performing:expression:comments:isRequired:sourceLocation:) ``` Initially I thought swift testing doesn't support test discovery in linked dylibs but it's apparently not the case. And according to gemini it's not anything else in a binary but ``` Load command 9 cmd LC_BUILD_VERSION platform 7 - minos 14.0 + minos 15.6 sdk 26.4 ``` As it tried to use `15.6` in `swift_flags` and put `14.0` in `ldflags` and hit the same crash. This is what gemini has to say: > This is the definitive end of the road! 🔬 > > I have mathematically eliminated every other variable in computing existence. Between a binary that crashes and a binary that runs, literally NOTHING changed except that single number. Also it thinks it's because of this in `dyld`: > Look at the code in dyldMain.cpp at Line 430: > > cpp > // dyldMain.cpp Line 430 > // TODO: Remove once drop support for simulators older than iOS 17, tvOS 15, and watchOS 8 > mach_o::PlatformAndVersions pvs = dyldSimHdr->platformAndVersions(); > mach_o::Policy policy(mach_o::Architecture(), pvs, 0); > // [!!] THE SMOKING GUN [!!] > // Old simulators add the main executable to all_image_info in the simulator process, not in the host > if ( policy.enforceImageListRemoveMainExecutable() ) { > STACK_ALLOC_ARRAY(const mach_header*, mhs, 1); > mhs.push_back(state.config.process.mainExecutableMF); > std::span<const mach_header*> mhSpan(&mhs[0], 1); > > // LITERALLY REMOVES THE IMAGE FROM THE TRACKING TABLE!! > state.externallyViewable->removeImages(state.persistentAllocator, ephemeralAllocator, mhSpan); > } > Why this triggers your exact crash: > The Condition: policy.enforceImageListRemoveMainExecutable() explicitly returns true for all binaries linked below a specific epoch (iOS 15/16). > The Destructive Action: Because dyld thinks it needs to work around an ancient Simulator bug, it explicitly calls removeImages, ripping your binary's tracking data directly out of the global tracking table (all_image_info). > The Crash: Modern Swift Testing and the Swift Runtime rely on scanning all_image_info to discover where the @test sections are in memory! > The Final Blow: Because dyld just destructively hid the image from the tracking table, the Swift Runtime couldn't look it up, failed to resolve the internal metadata pointers, and instantly crashed in swift_getTypeByMangledName. > By simply lying and writing minos 15.0 into the header, you caused policy.enforceImageListRemoveMainExecutable() to return false, totally disabling this destructive legacy workaround and leaving your image intact for Swift to find! 🔬🏆🏁 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
addstone
pushed a commit
that referenced
this pull request
Jul 20, 2026
flutter#187370) …gine (flutter#187268)" Reason for revert: removal of some snapshot binaries break mac code signing Looks like the removal of the MCP server snapshot (and others) caused the codesigning failure. Log from the Dart SDK roll that was in the reverted patch: https://dart.googlesource.com/sdk.git/+log/6833224264116d1becc20dd037d6c25c92194612..3cdc25e8ffe98c61b36af485573639dc833b75cb Failure logs for arm64 and x64 bots both show the same errors: * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20verify_binaries_pre_codesigned/5308 * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_x64%20verify_binaries_pre_codesigned/5305/overview Errors: ``` Expected binaries not found in cache: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/snapshots/analysis_server.dart.snapshot /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/snapshots/dart_mcp_server_aot.dart.snapshot /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/snapshots/dartdevc.dart.snapshot /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/snapshots/kernel-service.dart.snapshot If this commit is removing binaries from the cache, this test should be fixed by removing the relevant entry from either the "binariesWithEntitlements" or "binariesWithoutEntitlements" getters in dev/tools/lib/codesign.dart. ╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════ ║ UNEXPECTED ERROR! ║ Exception: Did not find all expected binaries! ║ #0 verifyExist (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:231:5) ║ <asynchronous suspension> ║ #1 verifyPreCodesignedTestRunner (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:40:3) ║ <asynchronous suspension> ║ flutter#2 _runFromList (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/utils.dart:727:7) ║ <asynchronous suspension> ║ flutter#3 main (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/test.dart:123:5) ║ <asynchronous suspension> ║ ║ The test.dart script should be corrected to catch this error and call foundError(). ║ Some tests are likely to have been skipped. ╚═══════════════════════════════════════════════════════════════════════════════ Step failed (retcode: 255) ``` This reverts commit 6d7a865. <!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
addstone
pushed a commit
that referenced
this pull request
Jul 20, 2026
Fixes flutter#184725 This PR makes the tool exit when building with XCode and we didn't parse any build setting. I understand that there are no cases where this map can be empty, as it includes the app bundle ID, which is required when building. If we don't exit, it can show unrelated error messages to the users which could be confusing and hard to debug. For instance, from the linked issue, one could end up getting: `No valid code signing certificates were found` simply because the development team build setting was not available, despite having valid certificates installed. Sample output: ``` [ +63 ms] executing: [/Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj/] /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios [ ] executing: [/Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj/] /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios [ +765 ms] Command line invocation: /Applications/Xcode-26.3.0.app/Contents/Developer/usr/bin/xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios Build settings from command line: BUILD_DIR = /Users/admin/builds/AEFj1IwjB/0/repo/build/ios 2026-04-06 17:36:53.692 xcodebuild[9020:45597] Writing error result bundle to /var/folders/4p/084k9rr96ld_w60n8rdr0wtm0000gn/T/ResultBundle_2026-06-04_17-36-0053.xcresult xcodebuild: error: Could not configure request to show build settings: Unable to find a destination matching the provided destination specifier: { generic:1, platform:iOS } Ineligible destinations for the "Runner" scheme: { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 26.2 is not installed. Please download and install the platform from Xcode > Settings > Components. } [ ] Unexpected failure to get Xcode build settings: ProcessException: Process exited abnormally with exit code 64: Command line invocation: /Applications/Xcode-26.3.0.app/Contents/Developer/usr/bin/xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios Build settings from command line: BUILD_DIR = /Users/admin/builds/AEFj1IwjB/0/repo/build/ios 2026-04-06 17:36:53.692 xcodebuild[9020:45597] Writing error result bundle to /var/folders/4p/084k9rr96ld_w60n8rdr0wtm0000gn/T/ResultBundle_2026-06-04_17-36-0053.xcresult xcodebuild: error: Could not configure request to show build settings: Unable to find a destination matching the provided destination specifier: { generic:1, platform:iOS } Ineligible destinations for the "Runner" scheme: { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 26.2 is not installed. Please download and install the platform from Xcode > Settings > Components. } Command: /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios. [ +2 ms] Archiving example.com.myapp... [ +25 ms] Migrating AppFrameworkInfo.plist contents [ ] Upgrading AppFrameworkInfo.plist [ ] Upgrading Podfile [ +9 ms] The Swift Package Manager feature is off. Skipping the migration that adds Swift Package Manager integration... [ +6 ms] executing: xattr -r -d com.apple.FinderInfo /Users/admin/builds/AEFj1IwjB/0/repo [+1948 ms] Failed to remove xattr com.apple.FinderInfo from /Users/admin/builds/AEFj1IwjB/0/repo [ +1 ms] executing: [/Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj/] /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios [ ] executing: [/Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj/] /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios [ +920 ms] Command line invocation: /Applications/Xcode-26.3.0.app/Contents/Developer/usr/bin/xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios Build settings from command line: BUILD_DIR = /Users/admin/builds/AEFj1IwjB/0/repo/build/ios 2026-04-06 17:36:56.608 xcodebuild[9023:45646] Writing error result bundle to /var/folders/4p/084k9rr96ld_w60n8rdr0wtm0000gn/T/ResultBundle_2026-06-04_17-36-0056.xcresult xcodebuild: error: Could not configure request to show build settings: Unable to find a destination matching the provided destination specifier: { generic:1, platform:iOS } Ineligible destinations for the "Runner" scheme: { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 26.2 is not installed. Please download and install the platform from Xcode > Settings > Components. } [ ] Unexpected failure to get Xcode build settings: ProcessException: Process exited abnormally with exit code 64: Command line invocation: /Applications/Xcode-26.3.0.app/Contents/Developer/usr/bin/xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios Build settings from command line: BUILD_DIR = /Users/admin/builds/AEFj1IwjB/0/repo/build/ios 2026-04-06 17:36:56.608 xcodebuild[9023:45646] Writing error result bundle to /var/folders/4p/084k9rr96ld_w60n8rdr0wtm0000gn/T/ResultBundle_2026-06-04_17-36-0056.xcresult xcodebuild: error: Could not configure request to show build settings: Unable to find a destination matching the provided destination specifier: { generic:1, platform:iOS } Ineligible destinations for the "Runner" scheme: { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 26.2 is not installed. Please download and install the platform from Xcode > Settings > Components. } Command: /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios. [ +66 ms] executing: which security [ +4 ms] executing: which openssl [ +22 ms] executing: security find-identity -p codesigning -v [ +57 ms] 1) <ID> "Apple Distribution: ACME. (<ID>)" 1 valid identities found [ +1 ms] ════════════════════════════════════════════════════════════════════════════════ No valid code signing certificates were found You can connect to your Apple Developer account by signing in with your Apple ID in Xcode and create an iOS Development Certificate as well as a Provisioning Profile for your project by: 1- Open the Flutter project's Xcode target with open ios/Runner.xcworkspace 2- Select the 'Runner' project in the navigator then the 'Runner' target in the project settings 3- Make sure a 'Development Team' is selected under Signing & Capabilities > Team. You may need to: - Log in with your Apple ID in Xcode first - Ensure you have a valid unique Bundle ID - Register your device with your Apple Developer Account - Let Xcode automatically provision a profile for your app 4- Build or run your project again 5- Trust your newly created Development Certificate on your iOS device via Settings > General > Device Management > [your new certificate] > Trust For more information, please visit: https://developer.apple.com/library/content/documentation/IDEs/Conceptual/ AppDistributionGuide/MaintainingCertificates/MaintainingCertificates.html Or run on an iOS simulator without code signing ════════════════════════════════════════════════════════════════════════════════ [ +1 ms] "flutter ipa" took 7,479ms. [ +2 ms] executing: sw_vers -productName [ +8 ms] Exit code 0 from: sw_vers -productName [ ] macOS [ ] executing: sw_vers -productVersion [ +6 ms] Exit code 0 from: sw_vers -productVersion [ ] 26.0 [ ] executing: sw_vers -buildVersion [ +6 ms] Exit code 0 from: sw_vers -buildVersion [ ] 25A354 [ ] executing: uname -m [ +10 ms] Exit code 0 from: uname -m [ ] arm64 [ +20 ms] No development certificates available to code sign app for device deployment [ ] #0 throwToolExit (package:flutter_tools/src/base/common.dart:34:3) #1 XcodeCodeSigningSettings._getCodeSigningBuildSettings (package:flutter_tools/src/ios/code_signing.dart:340:9) <asynchronous suspension> flutter#2 buildXcodeProject (package:flutter_tools/src/ios/mac.dart:322:26) <asynchronous suspension> flutter#3 _BuildIOSSubCommand.runCommand (package:flutter_tools/src/commands/build_ios.dart:986:37) <asynchronous suspension> flutter#4 BuildIOSArchiveCommand.runCommand (package:flutter_tools/src/commands/build_ios.dart:477:50) <asynchronous suspension> flutter#5 FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1590:27) <asynchronous suspension> flutter#6 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19) <asynchronous suspension> flutter#7 CommandRunner.runCommand (package:args/command_runner.dart:212:13) <asynchronous suspension> flutter#8 FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:496:9) <asynchronous suspension> flutter#9 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19) <asynchronous suspension> flutter#10 FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:431:5) <asynchronous suspension> flutter#11 FlutterCommandRunner.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:307:33) <asynchronous suspension> flutter#12 run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:104:11) <asynchronous suspension> flutter#13 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19) <asynchronous suspension> flutter#14 main (package:flutter_tools/executable.dart:103:3) <asynchronous suspension> [ ] Running 2 shutdown hooks [ ] Shutdown hooks complete [ +56 ms] exiting with code 1 ``` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Elijah Okoroh <okorohelijah@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beep boop. Your images are optimized!
Your image file size has been reduced by 25% 🎉
Details
📝 docs |
repo | 🙋🏾 issues | 🏪 marketplace
~Imgbot - Part of Optimole family