Skip to content

upgrade: masonry package upgrade for Solid 2.0#875

Merged
davedbase merged 2 commits intosolidjs-community:nextfrom
davedbase:update/v2/masonry
May 10, 2026
Merged

upgrade: masonry package upgrade for Solid 2.0#875
davedbase merged 2 commits intosolidjs-community:nextfrom
davedbase:update/v2/masonry

Conversation

@davedbase
Copy link
Copy Markdown
Member

  • mapArraycallback API changed**: in Solid 2.0 the value parameter is nowAccessorinstead ofT. The implementation now calls source()` inside the callback; the public API is unchanged.
  • createMemo drops the separate initial-value argument: createMemo(fn, void 0, options)createMemo(fn, options). The equals comparator for the column-count memo is now passed as the second argument directly.
  • createSignal type fixed: createSignal<VoidFunction | undefined>(undefined, { ownedWrite: true }) — explicit undefined requires the | undefined union; ownedWrite: true allows createMasonry to be safely called inside createRoot, component bodies, or effects without throwing SIGNAL_WRITE_IN_OWNED_SCOPE.
  • Tests restructured: signal setters (setColumns) moved outside the createRoot callback to satisfy Solid 2.0's owned-scope write restriction. flush() added after signal writes before assertions.
  • Peer dep bumped to solid-js@2.0.0-beta.10; version bumped to 1.0.0.
  • Fixed two pre-existing typos in README (provedeprovide, reacticereactive).

@davedbase davedbase added this to the Solid 2.0 Migration milestone May 5, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 5, 2026

🦋 Changeset detected

Latest commit: e4ba5e4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davedbase davedbase changed the title Port to Solid 2.0 beta 10 upgrade: masonry package upgrade for Solid 2.0 May 5, 2026
@davedbase davedbase marked this pull request as ready for review May 10, 2026 12:39
@davedbase davedbase merged commit 43dcd66 into solidjs-community:next May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants