Skip to content

fix: 썸네일 이미지 포맷 유지#35

Merged
lsy1307 merged 1 commit into
mainfrom
34-fix-thumbnail-lambda-extension
May 30, 2026
Merged

fix: 썸네일 이미지 포맷 유지#35
lsy1307 merged 1 commit into
mainfrom
34-fix-thumbnail-lambda-extension

Conversation

@lsy1307
Copy link
Copy Markdown
Contributor

@lsy1307 lsy1307 commented May 30, 2026

요약

  • 생성되는 썸네일 키에 원본 이미지 확장자를 반영합니다.
  • 썸네일 출력 인코딩을 원본 이미지 포맷에 맞춥니다.
  • S3 Content-Type을 썸네일 포맷에 맞게 설정합니다.

테스트

  • node --check modules\shared_resources\src\thumbnail\index.js

Summary by CodeRabbit

릴리스 노트

  • 새로운 기능

    • 썸네일이 이제 원본 이미지 형식(JPEG, PNG, WebP)을 유지합니다.
    • 썸네일 파일명이 원본 파일 확장자를 포함하도록 개선되었습니다.
  • 개선사항

    • S3 썸네일 생성 프로세스가 더욱 안정적으로 최적화되었습니다.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 30, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b2506e89-fc51-43fc-bb12-ea4132e7de3d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 34-fix-thumbnail-lambda-extension

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lsy1307 lsy1307 force-pushed the 34-fix-thumbnail-lambda-extension branch from a3ac0da to eaddff7 Compare May 30, 2026 05:06
@lsy1307 lsy1307 changed the title fix: preserve thumbnail image format fix: 썸네일 이미지 포맷 유지 May 30, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 30, 2026

Terraform Plan: global

Plan: 0 to add, 1 to change, 0 to destroy.

전체 plan 결과는 보안을 위해 댓글에 포함되지 않습니다. 워크플로우 실행 아티팩트를 확인하세요.

@lsy1307 lsy1307 self-assigned this May 30, 2026
@github-actions
Copy link
Copy Markdown

@coderabbitai review

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@modules/shared_resources/src/thumbnail/index.js`:
- Around line 62-64: The thumbnail key currently uses only the basename which
causes collisions; modify the thumbnailKey construction to preserve the original
object's path. Use the existing key (or derive directory via splitting or
path.dirname) and include that directory when building thumbnailKey (e.g.,
prepend the original directory between THUMBNAIL_PREFIX and the modified
filename) while still appending `${nameWithoutExt}_thumb${extension}`, and
ensure you handle keys with no directory (root) and avoid duplicate slashes;
update the variables fileName, nameWithoutExt, thumbnailKey, key, extension
accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4cac89ff-e251-451e-9ca0-23869db90e43

📥 Commits

Reviewing files that changed from the base of the PR and between 59f5f25 and eaddff7.

📒 Files selected for processing (1)
  • modules/shared_resources/src/thumbnail/index.js

Comment thread modules/shared_resources/src/thumbnail/index.js
Copy link
Copy Markdown
Contributor

@Hexeong Hexeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 고생하셨습니다~

@lsy1307 lsy1307 merged commit 54ef8ba into main May 30, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants