-
Notifications
You must be signed in to change notification settings - Fork 3
feat: 대학 정보 멀티존 분리 #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
manNomi
wants to merge
9
commits into
main
Choose a base branch
from
feat/university-ssg-multizone
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: 대학 정보 멀티존 분리 #543
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0ca99b8
feat: 대학 정보 멀티존 분리
manNomi 0ea25d2
chore: 멀티존 훅 검증 추가
manNomi 4031c46
chore: main 병합 충돌 해결
manNomi b3f301a
chore: 대학 정보 이동 린트 추가
manNomi 6334f77
chore: 대학 정보 릴리즈 타깃 추가
manNomi eae28e7
Merge pull request #544 from solid-connection/feat/release-university…
manNomi 845b892
fix: 대학 정보 Codex 리뷰 반영
manNomi 6f9376c
fix: 대학 멀티존 리뷰 반영 및 충돌 해결
manNomi c0da730
fix: 대학 목록 다중 권역 표시 보정
manNomi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # Shared configuration across all environments | ||
| # Environment-specific values are in .env.development, .env.preview, .env.production | ||
|
|
||
| NEXT_PUBLIC_IMAGE_URL=https://cdn.default.solid-connection.com | ||
| NEXT_PUBLIC_UPLOADED_IMAGE_URL=https://cdn.upload.solid-connection.com | ||
|
|
||
| # google maps | ||
| NEXT_PUBLIC_GOOGLE_MAP_API_KEY= | ||
|
|
||
| # google analytics | ||
| NEXT_PUBLIC_GOOGLE_ANALYTICS_ID=G-V1KLYZC1DS | ||
|
|
||
| # apple | ||
| NEXT_PUBLIC_APPLE_CLIENT_ID=com.basakcrispy.solidconnection.auth | ||
| NEXT_PUBLIC_APPLE_SCOPE="email" | ||
|
|
||
| NEXT_PUBLIC_CONTACT_LINK=https://open.kakao.com/o/grTrKWdg | ||
|
|
||
| # AI Inspector (server-only) | ||
| # Set these values in .env.local or deployment environment variables. | ||
| # AI_INSPECTOR_FIREBASE_PROJECT_ID= | ||
| # AI_INSPECTOR_FIREBASE_CLIENT_EMAIL= | ||
| # AI_INSPECTOR_FIREBASE_PRIVATE_KEY= | ||
| # AI_INSPECTOR_FIRESTORE_COLLECTION=aiInspectorTasks | ||
|
|
||
| # BELOW IS EXAMPLE FOR .env.local | ||
|
|
||
| # firebase private | ||
| # FIREBASE_PROJECT_ID= | ||
| # FIREBASE_PRIVATE_KEY_ID= | ||
| # FIREBASE_PRIVATE_KEY= | ||
| # FIREBASE_CLIENT_EMAIL= | ||
| # FIREBASE_CLIENT_ID= | ||
| # FIREBASE_CLIENT_X509_CERT_URL= | ||
|
|
||
| # sentry | ||
| # SENTRY_PROJECT= | ||
| # SENTRY_ORG= | ||
| # SENTRY_DSN= | ||
| # SENTRY_ENVIRONMENT= |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| SENTRY_ENVIRONMENT=development | ||
|
|
||
| # web page | ||
| NEXT_PUBLIC_WEB_URL=http://localhost:3000 | ||
|
|
||
| # api server | ||
| NEXT_PUBLIC_API_SERVER_URL=https://api.stage.solid-connection.com | ||
|
|
||
| # kakao | ||
| NEXT_PUBLIC_KAKAO_JS_KEY= |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| SENTRY_ENVIRONMENT=production | ||
|
|
||
| # web page | ||
| NEXT_PUBLIC_WEB_URL=https://www.solid-connection.com | ||
|
|
||
| # api server | ||
| NEXT_PUBLIC_API_SERVER_URL=https://api.solid-connection.com | ||
|
|
||
| # kakao | ||
| NEXT_PUBLIC_KAKAO_JS_KEY= |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| # Authentication & Authorization | ||
|
|
||
| ## Overview | ||
|
|
||
| 웹 인증은 **클라이언트 재발급/인터셉터 중심**으로 동작합니다. | ||
|
|
||
| - 서버 진입 시 middleware에서 보호 경로를 `/login`으로 선리다이렉트하지 않습니다. | ||
| - 인증 실패 시점은 페이지 렌더/데이터 요청 단계에서 결정됩니다. | ||
|
|
||
| ## Current Flow | ||
|
|
||
| ### 1. App Initialization | ||
|
|
||
| - `ReissueProvider`에서 앱 최초 진입 시 `/auth/reissue`를 시도합니다. | ||
| - 성공 시 access token이 스토어에 반영되고, 실패 시 비로그인 상태를 유지합니다. | ||
|
|
||
| ### 2. Request Interceptor | ||
|
|
||
| - `axiosInstance` 요청 인터셉터가 access token 만료 여부를 검사합니다. | ||
| - 토큰이 없거나 만료된 경우 재발급을 시도하고, 실패하면 로그인 이동을 유도합니다. | ||
|
|
||
| ### 3. Response Interceptor | ||
|
|
||
| - API 응답이 401이면 재발급 1회 후 원요청을 재시도합니다. | ||
| - 재시도 실패 시 로그인 페이지로 이동합니다. | ||
|
|
||
| ### 4. Page-level Guards | ||
|
|
||
| - 인증이 필요한 UI(예: 멘토 페이지)는 클라이언트에서 재발급/토큰 상태를 확인합니다. | ||
| - 필요한 경우 페이지 내부 로직에서 `/login`으로 이동합니다. | ||
|
|
||
| ## Middleware Responsibility | ||
|
|
||
| `apps/web/src/middleware.ts`는 현재 아래만 담당합니다. | ||
|
|
||
| - stage 환경 `robots.txt` 제어 | ||
| - 스캐너/프로브 경로 차단 (`.php`, `/.git`, `/wp-admin` 등) | ||
| - 정적 리소스 경로 제외 matcher 유지 | ||
|
|
||
| 즉, middleware는 더 이상 인증 선검증(보호 경로 강제 로그인 리다이렉트)을 수행하지 않습니다. | ||
|
|
||
| ## Tokens | ||
|
|
||
| ### Refresh Token | ||
|
|
||
| - HTTP-only 쿠키로 관리 | ||
| - 재발급 API 호출 시 서버가 검증 | ||
|
|
||
| ### Access Token | ||
|
|
||
| - Zustand store 기반으로 관리 | ||
| - API 인증 헤더에 사용 | ||
| - 만료 시 재발급을 통해 갱신 | ||
|
|
||
| ## Related Files | ||
|
|
||
| - `apps/web/src/lib/zustand/useAuthStore.ts` | ||
| - `apps/web/src/utils/axiosInstance.ts` | ||
| - `apps/web/src/components/layout/ReissueProvider/index.tsx` | ||
| - `apps/web/src/middleware.ts` |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: solid-connection/solid-connect-web
Length of output: 3441
CI 보안 강화: 액션 참조를 SHA로 고정하고 checkout에
persist-credentials: false추가하기university-web-quality-check/university-web-build의uses:가actions/checkout@v4,pnpm/action-setup@v3,actions/setup-node@v4처럼 태그 기반이라 공급망 리스크가 커서 커밋 SHA로 고정해 주세요.Checkout repository에persist-credentials: false가 없어 읽기 전용 체크아웃에서도 불필요한 자격 증명이 유지될 수 있으니 추가해 주세요.🔧 예시 수정안
🧰 Tools
🪛 zizmor (1.25.2)
[warning] 76-77: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
[error] 77-77: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy)
(unpinned-uses)
[error] 80-80: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy)
(unpinned-uses)
[error] 85-85: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy)
(unpinned-uses)
🤖 Prompt for AI Agents