Skip to content

refactor: magic 색상 토큰 정리#540

Merged
manNomi merged 4 commits into
mainfrom
feat/magic-color-tokens
Jun 2, 2026
Merged

refactor: magic 색상 토큰 정리#540
manNomi merged 4 commits into
mainfrom
feat/magic-color-tokens

Conversation

@manNomi
Copy link
Copy Markdown
Contributor

@manNomi manNomi commented Jun 2, 2026

관련 이슈

  • resolves: 없음

작업 내용

  • admin과 web에 흩어져 있던 하드코딩 색상을 magic-* 디자인 토큰으로 정리했습니다.
  • admin Tailwind v4 환경에 맞춰 @theme 기반 magic 색상 토큰과 shell 배경/그림자 유틸을 추가했습니다.
  • web Tailwind config에 상태, API method, 설문 모달, 하단 내비게이션, 댓글, 대학 상세 액션, 인증 예시 divider, shadow/gradient 토큰을 추가했습니다.
  • 주요 컴포넌트의 #hex, arbitrary gradient/shadow, inline gradient style을 Tailwind 토큰 기반 class로 교체했습니다.
  • 코드리뷰 중 발견한 미사용 magic.nav.shadow 토큰을 제거했습니다.

특이 사항

  • apps/web/src/constants/university.ts의 대학 브랜드 컬러 3개는 일반 디자인 시스템 토큰보다 브랜드 상수에 가까워 이번 범위에서는 유지했습니다.
  • admin의 기존 primary, k, bg 유틸 정의 값은 이미 시맨틱 토큰 역할을 하고 있어 이번 범위에서는 magic-*로 옮기지 않았습니다.
  • Vinext build의 route classification Unknown 메시지와 Node engine warning은 기존 환경성 경고이며, 이번 변경으로 새로 생긴 실패는 없습니다.

리뷰 요구사항 (선택)

  • magic-* 토큰명이 실제 사용 맥락과 맞는지 확인 부탁드립니다.
  • 대학 브랜드 컬러를 다음 차수에서 별도 브랜드 토큰으로 분리할지 의견 부탁드립니다.

검증

  • pnpm --filter @solid-connect/admin ci:check
  • pnpm --filter @solid-connect/web ci:check
  • pnpm --filter @solid-connect/admin build
  • pnpm --filter @solid-connect/web build
  • git diff --check

@manNomi manNomi requested review from enunsnv and wibaek as code owners June 2, 2026 06:02
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Warning

Review limit reached

@manNomi, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 9 minutes and 41 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d3ae7599-a3fa-4ba7-982e-7145b205f0be

📥 Commits

Reviewing files that changed from the base of the PR and between b9d7489 and ab71e25.

📒 Files selected for processing (27)
  • apps/admin/src/components/features/bruno/BrunoApiPageContent.tsx
  • apps/admin/src/components/features/mentor-applications/MentorApplicationsPageContent.tsx
  • apps/admin/src/components/features/regions-countries/RegionsCountriesPageContent.tsx
  • apps/admin/src/components/features/scores/ScoreVerifyButton.tsx
  • apps/admin/src/components/features/scores/StatusBadge.tsx
  • apps/admin/src/components/layout/AdminLayout.tsx
  • apps/admin/src/styles.css
  • apps/web/src/app/community/[boardCode]/PostWriteButton.tsx
  • apps/web/src/app/community/[boardCode]/[postId]/CommentSection.tsx
  • apps/web/src/app/mentor/chat/_ui/ChatPageClient/index.tsx
  • apps/web/src/app/university/[homeUniversity]/[id]/_ui/UniversityDetail/_ui/UniversityBtns.tsx
  • apps/web/src/app/university/score/example/gpa-cert/page.tsx
  • apps/web/src/components/layout/GlobalLayout/ui/BottomNavigation/index.tsx
  • apps/web/src/components/layout/GlobalLayout/ui/BottomNavigation/ui/DegreeHat.tsx
  • apps/web/src/components/layout/GlobalLayout/ui/BottomNavigation/ui/EditTwo.tsx
  • apps/web/src/components/layout/GlobalLayout/ui/BottomNavigation/ui/Home.tsx
  • apps/web/src/components/layout/GlobalLayout/ui/BottomNavigation/ui/Human.tsx
  • apps/web/src/components/layout/GlobalLayout/ui/BottomNavigation/ui/WhatsNew.tsx
  • apps/web/src/components/layout/GlobalLayout/ui/BottomNavigation/ui/World.tsx
  • apps/web/src/components/login/signup/SignupPrepareScreen.tsx
  • apps/web/src/components/modal/SurveyModal.tsx
  • apps/web/src/components/ui/Dropdown/index.tsx
  • apps/web/src/components/ui/SlimDropdown.tsx
  • apps/web/src/components/ui/icon/star-filled.tsx
  • apps/web/src/lib/toast/showIconToast.tsx
  • apps/web/tailwind.config.ts
  • packages/ui/src/button.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/magic-color-tokens

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-web-admin Ready Ready Preview, Comment Jun 2, 2026 6:12am
solid-connection-web Ready Ready Preview, Comment Jun 2, 2026 6:12am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant