Skip to content

refactor: 공통 UI 패키지 기반 구축#539

Merged
manNomi merged 1 commit into
mainfrom
feat/shared-ui-primitives-admin
Jun 2, 2026
Merged

refactor: 공통 UI 패키지 기반 구축#539
manNomi merged 1 commit into
mainfrom
feat/shared-ui-primitives-admin

Conversation

@manNomi
Copy link
Copy Markdown
Contributor

@manNomi manNomi commented Jun 1, 2026

작업 내용

  • @solid-connect/ui 패키지를 추가해 공통 UI primitive 기반을 마련했습니다.
  • admin의 Button, Input, Textarea, Card, Table, Tabs, Label, cn을 shared package로 옮기고 기존 admin components/ui/* 파일은 re-export shim으로 유지했습니다.
  • admin Tailwind v4가 shared UI class를 스캔하도록 @source를 추가했습니다.
  • admin에서 더 이상 직접 사용하지 않는 Radix/CVA/clsx/tailwind-merge 의존성을 정리했습니다.

검증

  • pnpm --filter @solid-connect/ui ci:check
  • pnpm --filter @solid-connect/admin ci:check
  • pnpm --filter @solid-connect/admin build
  • git diff --check
  • commit hook: @solid-connect/web ci:check, @solid-connect/admin ci:check
  • push hook: @solid-connect/web ci:check, @solid-connect/web build, @solid-connect/admin ci:check, @solid-connect/admin build

참고

  • PR은 origin/main 기준 새 브랜치에서 생성해 React Compiler 변경이 섞이지 않도록 정리했습니다.
  • web의 shared UI 소비는 Next/RSC 및 Tailwind v3 content 설정을 별도로 검증해야 하므로 후속 PR 범위로 남겼습니다.
  • 로컬 Node가 v23.10.0이라 node 22.x engine warning은 출력됐지만 검증 명령은 모두 통과했습니다.

@manNomi manNomi requested review from enunsnv and wibaek as code owners June 1, 2026 07:15
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-web-admin Ready Ready Preview, Comment Jun 1, 2026 7:16am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connection-web Skipped Skipped Jun 1, 2026 7:16am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Warning

Review limit reached

@manNomi, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 45 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d10fd019-8540-4abe-bc5a-ecaf2b9ecb25

📥 Commits

Reviewing files that changed from the base of the PR and between 857e527 and 798b0b3.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (22)
  • apps/admin/package.json
  • apps/admin/src/components/ui/button.tsx
  • apps/admin/src/components/ui/card.tsx
  • apps/admin/src/components/ui/input.tsx
  • apps/admin/src/components/ui/label.tsx
  • apps/admin/src/components/ui/table.tsx
  • apps/admin/src/components/ui/tabs.tsx
  • apps/admin/src/components/ui/textarea.tsx
  • apps/admin/src/lib/utils/index.ts
  • apps/admin/src/styles.css
  • packages/ui/biome.json
  • packages/ui/package.json
  • packages/ui/src/button.tsx
  • packages/ui/src/card.tsx
  • packages/ui/src/cn.ts
  • packages/ui/src/index.ts
  • packages/ui/src/input.tsx
  • packages/ui/src/label.tsx
  • packages/ui/src/table.tsx
  • packages/ui/src/tabs.tsx
  • packages/ui/src/textarea.tsx
  • packages/ui/tsconfig.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/shared-ui-primitives-admin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@manNomi
Copy link
Copy Markdown
Contributor Author

manNomi commented Jun 2, 2026

@codex review 한국어로 리뷰해줘. 코드 식별자는 영어 원문을 유지하고, 실제 버그/회귀/테스트 누락 위주로 봐줘.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@manNomi manNomi merged commit b9d7489 into main Jun 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant