Skip to content

chore(language-server): integrate LS#6908

Open
team-ide-user wants to merge 1 commit into
mainfrom
chore/automatic-upgrade-of-ls
Open

chore(language-server): integrate LS#6908
team-ide-user wants to merge 1 commit into
mainfrom
chore/automatic-upgrade-of-ls

Conversation

@team-ide-user

@team-ide-user team-ide-user commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Changes since last integration of Language Server

commit 07f9771388bfdd967bc3e2b56e187164a22d3908
Author: Ben Durrans <Benjamin.Durrans@snyk.io>
Date:   Mon Jun 15 14:38:29 2026 +0100

    fix: fallback to global org for LDX-Sync API call [IDE-1974] (#1236)
    
    But only when `OrgSetByUser` is `true` and `PreferredOrg` is `""`.
    When changing the global org in this scenario, also refresh from LDX-Sync for the applicable folder configs.
    On init, handle the IDE config before fetching from LDX-Sync so we have the correct API endpoint, global org, etc.
    Revert back to the global org just being stored in GAF, as the changes to use `UserGlobalKey` were getting out of hand for a scope we don't even support.
    Do not send any diagnostics on initialisation while we're still half loading the IDE config in.
    Make the FF service use the standard method for getting a folder's org, as the logic did not have the global org fallback logic correct.
    Only fetch FFs and config from LDX-Sync on folder level org changes if LS is initialised. This prevents redundant API calls for the wrong org (plus, as mentioned above, changed to get all orgs after IDE configuration is loaded).

M	application/config/config.go
M	application/config/config_test.go
M	application/server/configuration.go
M	application/server/configuration_test.go
M	application/server/server.go
M	application/server/server_smoke_test.go
M	application/server/server_test.go
M	domain/ide/command/configuration_command.go
M	domain/ide/command/folder_handler_test.go
M	domain/ide/command/ldx_sync_service.go
M	domain/ide/command/ldx_sync_service_test.go
M	domain/ide/command/login_test.go
M	domain/ide/command/mock/ldx_sync_service_mock.go
M	infrastructure/cli/cli_extension_executor_test.go
M	infrastructure/featureflag/fake_featureflag.go
M	infrastructure/featureflag/featureflag.go
M	infrastructure/featureflag/featureflag_test.go
M	internal/types/config_readers.go
A	internal/types/config_readers_test.go
M	internal/types/config_resolver.go
M	internal/types/config_resolver_delegation_test.go
M	internal/types/config_resolver_test.go
M	internal/types/folder_config.go
A	internal/util/ternary.go
A	internal/util/ternary_test.go

@team-ide-user team-ide-user requested a review from a team as a code owner June 15, 2026 14:09
@team-ide-user team-ide-user enabled auto-merge June 15, 2026 14:09
@snyk-io

snyk-io Bot commented Jun 15, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown
Contributor
Warnings
⚠️

"chore: automatic integration of language server 07f9771388bfdd967bc3e2b56e187164a22d3908" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against 62f1cdb

@snyk-pr-review-bot

Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected
📚 Repository Context Analyzed

This review considered 4 relevant code sections from 4 files (average relevance: 0.98)

🤖 Repository instructions applied (from AGENTS.md)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant