chore: remove rate-limit retry warnings from test stderr#6907
Open
danskmt wants to merge 1 commit into
Open
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This comment has been minimized.
This comment has been minimized.
1004ea0 to
b14bf6b
Compare
This comment has been minimized.
This comment has been minimized.
b14bf6b to
037fc31
Compare
This comment has been minimized.
This comment has been minimized.
037fc31 to
e17f0ce
Compare
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Stops acceptance tests from failing when CI is briefly rate-limited. CLI-1512 prints a
SNYK-0001retry warning to stderr; if the request succeeds after retry, tests that expect empty stderr still fail.The shared test runner now removes those transient retry warnings from captured stderr. Only blocks with
Automatically retrying inare removed, so real failures after retries are still shown.Where should the reviewer start?
test/jest/util/stripRetryWarnings.ts- stripping logictest/jest/util/runCommand.ts- applies it to captured stderrtest/jest/util/stripRetryWarnings.spec.ts- unit testsHow should this be manually tested?
npx jest test/jest/util/stripRetryWarnings.spec.ts1/3 -> 2/3 -> successand1/3 -> 2/3 -> fail.What's the product update that needs to be communicated to CLI users?
None. Test-only change.