Skip to content

feat: show TEST_SNYK_IGNORE_LIST patterns in the pipeline#6906

Open
robertolopezlopez wants to merge 1 commit into
mainfrom
feat/CLI-1584
Open

feat: show TEST_SNYK_IGNORE_LIST patterns in the pipeline#6906
robertolopezlopez wants to merge 1 commit into
mainfrom
feat/CLI-1584

Conversation

@robertolopezlopez

@robertolopezlopez robertolopezlopez commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

Currently circleci masks the content of process.env.TEST_SNYK_IGNORE_LIST in the pipelines, which is not really helpful. This PR tries to address that.

Where should the reviewer start?

How should this be manually tested?

Look at the pipeline

What's the product update that needs to be communicated to CLI users?

Screenshots (if appropriate)

  • Before
    image
  • After
    image

@snyk-io

snyk-io Bot commented Jun 15, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@robertolopezlopez robertolopezlopez marked this pull request as ready for review June 16, 2026 11:01
@robertolopezlopez robertolopezlopez requested a review from a team as a code owner June 16, 2026 11:01
@snyk-pr-review-bot

Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Unsafe Array Operation 🟠 [major]

The call to getTestSnykIgnoreListPatterns().reduce(...) assumes that the function always returns an array. If TEST_SNYK_IGNORE_LIST is not defined or the function returns null/undefined, this will throw a TypeError: Cannot read property 'reduce' of undefined, causing the global test setup to fail and preventing any tests from running. A guard or default empty array should be used.

getTestSnykIgnoreListPatterns().reduce(
  (acc, pattern) => acc + '\n   ' + pattern,
  '\n Ignore those test files [TEST_SNYK_IGNORE_LIST] ...',
) +
📚 Repository Context Analyzed

This review considered 7 relevant code sections from 6 files (average relevance: 0.93)

🤖 Repository instructions applied (from AGENTS.md)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant