fix(sui): expose a function to infer roles from action - #829
Merged
Conversation
FelixFan1992
changed the title
FelixFan1992
marked this pull request as ready for review
August 17, 2026 22:45
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an exported helper in the Sui SDK to infer the appropriate TimelockRole from a types.TimelockAction, aligning Sui with existing chain SDK patterns (e.g., Aptos/Canton) and making role inference reusable by callers.
Changes:
- Added
SuiRoleFromAction(action types.TimelockAction) (TimelockRole, error)to map timelock actions to SuiTimelockRoles. - Added a table-driven unit test covering the supported actions and the unknown-action error path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/sui/sui_helpers.go | Exposes SuiRoleFromAction for mapping TimelockAction → TimelockRole. |
| sdk/sui/chain_metadata_test.go | Adds test coverage for SuiRoleFromAction across known and unknown actions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gustavogama-cll
approved these changes
Aug 18, 2026
FelixFan1992
enabled auto-merge (squash)
August 18, 2026 03:32
gustavogama-cll
changed the title
gustavogama-cll
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CCIP-13068