Skip to content

feat: Add TimelockConfigurer.GrantRole support for TON - #821

Merged
gustavogama-cll merged 4 commits into
mainfrom
feat/ton-grant-role
Aug 13, 2026
Merged

feat: Add TimelockConfigurer.GrantRole support for TON#821
gustavogama-cll merged 4 commits into
mainfrom
feat/ton-grant-role

Conversation

@krebernisak

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings July 29, 2026 16:39
@krebernisak
krebernisak requested a review from a team as a code owner July 29, 2026 16:39
@github-actions

Copy link
Copy Markdown

👋 krebernisak, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds TON support for TimelockConfigurer.GrantRole by introducing TON-specific timelock role hashing and implementing the on-chain (and prepared/skipSend) GrantRole message flow.

Changes:

  • Added TON TimelockRoleHash mapping to TON timelock role constants.
  • Implemented TimelockConfigurer.GrantRole for TON, including deterministic query ID generation for prepared transactions.
  • Added unit tests covering GrantRole success/failure cases and deterministic prepared transaction behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
sdk/ton/timelock_role.go Introduces TON role-hash lookup for sdk.TimelockRole values.
sdk/ton/timelock_configurer.go Implements GrantRole and refactors query ID generation into a helper.
sdk/ton/timelock_configurer_test.go Adds test coverage for the new TON GrantRole behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sdk/ton/timelock_role.go Outdated
@krebernisak krebernisak changed the title Add TimelockConfigurer.GrantRole support for TON feat: Add TimelockConfigurer.GrantRole support for TON Jul 29, 2026
@krebernisak
krebernisak enabled auto-merge (squash) August 12, 2026 18:43
ecPablo
ecPablo previously approved these changes Aug 12, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 13, 2026 02:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings August 13, 2026 02:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings August 13, 2026 04:13
@cl-sonarqube-production

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

sdk/ton/timelock_configurer_test.go:265

  • These subtests are marked t.Parallel(), but the per-case mockSetup closures capture the parent t (e.g. ton_mocks.NewAPIClientWrapped(t)). That means multiple subtests can end up sharing the same parent *testing.T concurrently, which can cause races/flaky behavior and mis-attributed failures. Either pass the subtest t into mockSetup (preferred) or don’t run the subtests in parallel.
		t.Run(tt.name, func(t *testing.T) {
			t.Parallel()

@gustavogama-cll
gustavogama-cll merged commit 541ae5d into main Aug 13, 2026
21 checks passed
@gustavogama-cll
gustavogama-cll deleted the feat/ton-grant-role branch August 13, 2026 13:56
gustavogama-cll pushed a commit that referenced this pull request Aug 18, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.53.0](v0.52.1...v0.53.0)
(2026-08-18)


### Features

* Add TimelockConfigurer.GrantRole support for TON
([#821](#821))
([541ae5d](541ae5d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: app-token-issuer-ops-platform[bot] <275822481+app-token-issuer-ops-platform[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants