chore: add default app icon#75
Conversation
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
WilliamBergamin
left a comment
There was a problem hiding this comment.
Thanks for working on this, I'm not sure if this change should be applied to this project, the project is not setup to work with the CLI adding the icon will have no effect 😅
|
@WilliamBergamin I'm curious to open an adjacent PR for default CLI support? We have a solid |
|
@zimeg yess we can introduce support for the CLI in this project 💯 Even if it add background time to CI I think its fine, if the time becomes a problem in the future then we will address it |
zimeg
left a comment
There was a problem hiding this comment.
LGTM - I look forward to set-icon experiments concluding stable! 🔮
|
@WilliamBergamin thanks for letting me know this doesnt have CLI support! i did get an approval from @zimeg though - does that mean i can merge now or we wait for CLI support 🔮 🤔 |
Summary
assets/icon.pngTest plan
slack run --experiment set-iconand confirm the icon appears on the app