Skip to content

improvement(ui): use shared sizing for auth controls - #8162

Merged
waleedlatif1 merged 1 commit into
codex/control-fix-account-status-headingsfrom
codex/overrides-auth-sizing
Sep 22, 2026
Merged

waleedlatif1 merged 1 commit into
codex/control-fix-account-status-headingsfrom
codex/overrides-auth-sizing

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Auth, invite, unsubscribe and public-file controls now use shared Chip/ChipInput size="lg" and align="center". Retires the height/alignment constants and moves the SSO email link to ChipLink. Labels, URLs, validation, reveal behavior, loading/disabled states and handlers remain unchanged.

Intentional differences: 34→36px fields; SSO email action 32→36px height, 12→14px text and 10→8px corners with the shared outline treatment. Existing 36px auth actions retain their geometry.

All workspace type checks, import/API audits, lint and the complete EMCN suite pass; all 44 relevant consumer tests pass. Browser fixtures cover light/dark, error/reveal, focus/hover, disabled/loading, 390px embedded document viewports and enlarged text. Backend auth/invite/unsubscribe/provider/Slack services were not exercised. No linter or review artifacts are included.

Both external linters ran against the actual target: 17 targeted findings removed (732 → 715 total), no new full-scan findings, and zero diff-checker violations.

@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 22, 2026 9:33pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 17 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the shared component APIs preserve the intended geometry and existing interaction behavior.

Summary

This PR consolidates auth-adjacent control geometry onto the shared EMCN sizing and alignment APIs.

  • Replaces local height and descendant-flex overrides with size='lg' and align='center'.
  • Removes the now-unused auth sizing constants.
  • Standardizes password, email, public-file, invite, unsubscribe, OAuth consent, and Slack setup fields.
  • Replaces the nested SSO email Link/Button composition with the canonical ChipLink while preserving callback handling.
  • Updates the SSO test mocks for the shared component APIs.

Reviews (1) · Last reviewed commit: "improvement(ui): use shared sizing for a..."

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before → after visual checks for 4c26fc6. Actual password/submit wrappers plus equivalent social, invitation, SSO and secret controls, with local handlers. Backend authentication/invitation/unsubscribe/provider/Slack services were not exercised.

Most auth controls retain 36px geometry. Public fields grow 34→36px. The SSO email link adopts 36px height, 14px text, 8px corners and shared outline styling.

Light — before left, after right:
clipboard

Dark — before left, after right:
clipboard

Password error — 2× enlarged crop:
clipboard

390px document viewports with enlarged text (20px root), before / after. Both documents measured 390px client width and scroll width:
clipboard

@waleedlatif1
waleedlatif1 merged commit 5d7f002 into codex/control-fix-account-status-headings Sep 22, 2026
11 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/overrides-auth-sizing branch September 22, 2026 21:42

This branch was previously deployed

1 inactive deployment
Preview — 4c26fc6e Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants