Skip to content

improvement(emcn): share larger chip and field geometry - #8151

Merged
waleedlatif1 merged 1 commit into
codex/emcn-consolidationfrom
codex/overrides-chip-sizing
Sep 23, 2026
Merged

waleedlatif1 merged 1 commit into
codex/emcn-consolidationfrom
codex/overrides-chip-sizing

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Auth fields currently override ChipInput height locally, and full-width chip actions center their labels through descendant classes. Add shared size="lg" geometry to Chip, ChipLink and ChipInput, plus align="center" for chip actions; migrate AuthInput to the shared size.

Defaults stay 30px. Auth geometry remains 36px (45px with enlarged root text). Centered long labels can shrink in narrow layouts. Two wrapper type exclusions keep marketing CTA sizes and secret fields on their existing APIs; their rendering is unchanged.

Validation: all 26 workspace type checks, import/API audits, lint and 381 EMCN tests pass. Both conformance linters ran against the actual base: the AuthInput height override is removed, no new usage violations. Browser comparisons cover both themes, hover, focus, disabled/error states, enlarged text and narrow forms using actual components in a labeled local fixture; native form submission was exercised. Auth service calls were not exercised. Before/after screenshots follow in a comment.

@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 22, 2026 7:58pm UTC

Request Review

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before / after — actual AuthInput and EMCN components with local test data. The full comparisons use identical browser settings; the closeups are 2× enlargements.

clipboard clipboard clipboard clipboard

Both themes retain the same 36px auth height, colours and corners; default chips remain 30px. With 20px root text the auth controls grow to 45px on both sides. At 390px width, centered long labels now shrink within the icon group instead of overrunning it.

Also exercised: hover, keyboard focus, disabled/error states and native form submission. These are actual components in a labeled external fixture; no authentication service calls were made. Base 81e3110265ea; head 7eb9cc4c9c74.

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no actionable correctness, security, or repository-rule violations were identified.

Summary

This PR consolidates larger chip geometry and centered chip-action alignment into shared EMCN APIs.

  • Adds md and lg sizing to Chip, ChipLink, and ChipInput while retaining the 30px default.
  • Adds shrink-safe centered alignment for chip actions.
  • Migrates AuthInput to the shared large size and protects wrapper-specific size contracts.
  • Adds coverage for geometry, prop forwarding, refs, focus, form submission, disabled behavior, and links.

Reviews (1) · Last reviewed commit: "improvement(emcn): share larger chip and..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 380bf5d into codex/emcn-consolidation Sep 23, 2026
14 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/overrides-chip-sizing branch September 23, 2026 02:11
BillLeoutsakosvl346 added a commit that referenced this pull request Sep 24, 2026
* improvement(emcn): share ordinary action geometry in Button

* improvement(emcn): consolidate selection controls and styling options

* test(emcn): read email geometry from the public export

* improvement(emcn): share larger chip and field geometry (#8151)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* refactor(ui): use EMCN fields in deployment and setup modals (#8009)

* improvement(emcn): share larger chip and field geometry

* refactor(ui): use EMCN fields in deployment and setup modals

* improvement(ui): reuse chip for PII configuration action (#8173)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): compose horizontal and credential fields in EMCN (#8164)

* improvement(ui): compose horizontal and credential fields in EMCN

* Share deploy chat field error treatment (#8255)

* refactor(ui): share deploy chat field error treatment

* refactor(ui): name deploy error props

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): share knowledge filter headings (#8073)

* improvement(ui): share knowledge filter headings

* improvement(ui): share inline filter and pagination actions (#8163)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): use chip fields in workflow search and replace (#8076)

* improvement(emcn): share larger chip and field geometry

* improvement(ui): use chip fields in workflow search and replace

* fix(ui): use shared centered chip content on chat errors

* improvement(ui): use chips for ordinary product actions (#8081)

* improvement(ui): use chips for ordinary product actions

* improvement(ui): use shared chip alignment

* improvement(ui): use shared search action sizes (#8160)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): reuse chips for custom block upload actions (#8084)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* fix(chat): use native attachment action (#8265)

* fix(chat): use native attachment action

* fix(chat): retain disabled attachment tooltip

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* fix(chat): use EMCN icon button target for attachments

* refactor(ui): centralize destructive ghost button colors in EMCN (#7988)

* improvement(emcn): share larger chip and field geometry

* refactor(ui): use EMCN fields in deployment and setup modals

* refactor(ui): centralize destructive ghost button colors in EMCN

* improvement(ui): use standard knowledge tag icon size

* refactor(ui): consolidate product corner radii

* improvement(ui): reuse chip for PII configuration action (#8173)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* refactor(ui): share collapsible workflow field cards (#8017)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): compose horizontal and credential fields in EMCN (#8164)

* improvement(ui): compose horizontal and credential fields in EMCN

* Share deploy chat field error treatment (#8255)

* refactor(ui): share deploy chat field error treatment

* refactor(ui): name deploy error props

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Co-authored-by: Waleed <walif6@gmail.com>

* improvement(ui): share public headings and product typography (#8069)

* improvement(emcn): share larger chip and field geometry

* improvement(ui): share public authentication headings

* improvement(ui): share workflow panel tab buttons (#8072)

* improvement(ui): share workflow panel tab buttons

* improvement(ui): reuse chips for panel selection actions (#8166)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* refactor(ui): share account headings and auth control sizing (#8074)

* improvement(ui): share account status headings

* improvement(ui): use shared sizing for auth controls

* refactor(emcn): share invalid OTP slot treatment (#8246)

* Add shared invalid state to EMCN OTP slots

* fix(ui): distinguish OTP verification from resend errors

* test(ui): type OTP input queries as inputs

* test(ui): import OTP test button prop type

* test(ui): use shared logger mock in OTP regression

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Co-authored-by: Waleed <walif6@gmail.com>

* improvement(ui): share missing resource states (#8078)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): reuse avatars for owners and members (#8079)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* fix(ui): adopt exact shared 18px typography token

* fix(ui): preserve panel and auth control semantics

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Co-authored-by: Waleed <walif6@gmail.com>

* fix(ui): preserve shared tag actions and product styling fallbacks

* fix(ui): keep logs filters on canonical chip height

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Waleed <walif6@gmail.com>

This branch was successfully deployed

1 active deployment
Preview — 7eb9cc4c Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants