fix(emcn): preserve editable combobox overlay text visibility by BillLeoutsakosvl346 · Pull Request #8086 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-21T01:43:19Z

Summary

Keep editable Combobox input text transparent beneath formatted label and selected-icon overlays, even when caller classes specify a text color.
Preserve caller styling and ordinary text visibility when no overlay is present.

Type of Change

Bug fix

Testing

All workspace type checks, repository lint, audits (including import and API validation), and generated-artifact checks pass.
Complete EMCN suite and relevant existing consumer tests pass.
Focused regression coverage checks formatted-label, selected-icon and no-overlay cases with caller text-color overrides.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

BillLeoutsakosvl346 · 2026-09-21T01:43:22Z

@greptile

vercel · 2026-09-21T01:43:23Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 24, 2026 10:06pm UTC

BillLeoutsakosvl346 · 2026-09-21T01:43:24Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-21T01:43:29Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

greptile-apps · 2026-09-21T01:45:51Z

Confidence Score: 5/5

The PR appears safe to merge; the overlay condition and transparency condition remain aligned, and no outstanding findings remain.

Summary

This PR fixes editable Combobox overlay text visibility by ensuring the native input’s transparent-text class takes precedence over caller-provided text colors.

Applies transparency only when a formatted-label or selected-icon overlay is present.
Preserves caller styling and ordinary input text visibility without an overlay.
Adds regression coverage for label, icon, and no-overlay states with a conflicting caller text-color class.

_{Reviews (5) · Last reviewed commit: "fix(emcn): preserve editable combobox ov..."}

cubic-dev-ai

No issues found across 18 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

cubic-dev-ai

No issues found across 18 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-21T04:17:49Z

@greptile

BillLeoutsakosvl346 · 2026-09-21T04:17:50Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-21T04:17:54Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 2 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-21T04:23:17Z

@greptile

BillLeoutsakosvl346 · 2026-09-21T04:23:18Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-21T04:23:23Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 2 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-21T04:28:18Z

@greptile

BillLeoutsakosvl346 · 2026-09-21T04:28:19Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-21T04:28:24Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 2 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-21T17:59:34Z

Before / after visual comparison

Editable combobox overlays now take precedence over caller text-color classes. This prevents the raw value and formatted overlay from drawing on top of each other. The plain-input row remains unchanged.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Fresh regression fixture covering formatted-label, selected-icon and no-overlay modes. This illustrates the retained Combobox fix, not the withdrawn workflow-picker migrations.

Current PR head checked at posting: 155950dd45.

BillLeoutsakosvl346 · 2026-09-22T21:09:54Z

@greptile

BillLeoutsakosvl346 · 2026-09-22T21:09:55Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-22T21:10:01Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 2 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

* refactor(workflow): share mirrored input and textarea editing * test(workflow): use absolute mirrored field import * refactor(workflow): declare mirrored props and class states * style(workflow): express mirrored overlay constants as classes --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

vercel Bot deployed to Preview September 21, 2026 01:45 View deployment

cubic-dev-ai Bot reviewed Sep 21, 2026

View reviewed changes

BillLeoutsakosvl346 changed the title ~~improvement(ui): reuse chip controls for remaining workflow pickers~~ fix(emcn): preserve editable combobox overlay text visibility Sep 21, 2026

BillLeoutsakosvl346 changed the base branch from codex/control-fix-bounded-choice-menus to codex/control-fix-parameter-cards September 21, 2026 04:17

vercel Bot temporarily deployed to Preview September 21, 2026 04:17 Inactive

cubic-dev-ai Bot reviewed Sep 21, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 21, 2026

View reviewed changes

Comment thread packages/emcn/src/components/combobox/combobox.dom.test.tsx Outdated

vercel Bot deployed to Preview September 21, 2026 04:24 View deployment

cubic-dev-ai Bot reviewed Sep 21, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 21, 2026

View reviewed changes

Comment thread packages/emcn/src/components/combobox/combobox.dom.test.tsx

cubic-dev-ai Bot reviewed Sep 21, 2026

View reviewed changes

BillLeoutsakosvl346 force-pushed the codex/control-fix-parameter-cards branch from af1ee02 to b8c83e8 Compare September 22, 2026 20:48

fix(emcn): preserve editable combobox overlay text visibility

de7d26f

BillLeoutsakosvl346 force-pushed the codex/control-fix-remaining-workflow-pickers branch from 155950d to de7d26f Compare September 22, 2026 21:09

cubic-dev-ai Bot reviewed Sep 22, 2026

View reviewed changes

vercel Bot deployed to Preview September 22, 2026 21:11 View deployment

BillLeoutsakosvl346 mentioned this pull request Sep 24, 2026

Share mirrored workflow field editing treatment #8248

Merged

vercel Bot temporarily deployed to Preview September 24, 2026 22:06 Inactive

BillLeoutsakosvl346 merged commit 8774e90 into codex/control-fix-parameter-cards Sep 24, 2026
6 checks passed

waleedlatif1 deleted the codex/control-fix-remaining-workflow-pickers branch September 24, 2026 23:58

Conversation

BillLeoutsakosvl346 commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Uh oh!

vercel Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 21, 2026

Uh oh!

greptile-apps Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 21, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 21, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 21, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Before / after visual comparison

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

BillLeoutsakosvl346 commented Sep 21, 2026 •

edited

Loading

vercel Bot commented Sep 21, 2026 •

edited

Loading

greptile-apps Bot commented Sep 21, 2026 •

edited

Loading