Skip to content

fix(activity): keep unsuccessful tool labels neutral - #7951

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/neutral-tool-activity-labels
Sep 17, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/neutral-tool-activity-labels

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Keep unsuccessful tool activity labels neutral in inline headers and expanded history.
  • Normalize historical outcome prefixes without changing execution status, actionable errors, or stopped/skipped labels.

Type of Change

  • Bug fix

Testing

852 focused tests passed, including rendered activity across all agent types. App type-check, lint, all 46 repository audits, block registry validation, and docs manifest checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 17, 2026 11:33pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the label normalization is consistently applied and covered without changing execution state or actionable error handling.

Summary

This PR changes unsuccessful tool activity labels from failure-prefixed wording to neutral action descriptions while preserving stopped and skipped outcomes.

  • Adds normalization for historical leading outcome prefixes.
  • Applies neutral labels consistently to inline activity, grouped summaries, and expanded history.
  • Updates focused tests across tool-display and agent activity rendering.

Reviews (1) · Last reviewed commit: "fix(activity): keep unsuccessful tool la..."

@waleedlatif1
waleedlatif1 merged commit 0853431 into staging Sep 17, 2026
25 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/neutral-tool-activity-labels branch September 17, 2026 23:36

This branch was previously deployed

1 inactive deployment
Preview ff859ac8 Deployed Sep 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant