Skip to content

fix(search): preserve Google sync diagnostics and retry transient failures - #7895

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/google-sync-diagnostics
Sep 16, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/google-sync-diagnostics

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve Google API operation, HTTP status, and allowlisted error reasons without storing provider payloads. Keep Directory permission failures distinct from file access failures.
  • Retry Gmail and Calendar server errors and structured rate-limit responses within the existing transport budget. Preserve authentication, missing-document, and incomplete-directory behavior.
  • Store and report database driver codes instead of query text, bound parameters, or raw database causes in both Trigger and in-process document workers. Update Google connector troubleshooting docs.

Type of Change

  • Bug fix

Testing

  • 569 targeted connector, Directory, diagnostics, and document-processing tests passed, including regressions for retries, bounded error parsing, admission hooks, nested-group denials, both worker paths, and SQL redaction.
  • TypeScript, lint, API-contract validation, all 46 repository audits, block-registry validation, and docs-manifest checks passed.
  • Reviewed all eight cleanup passes; no client state or UI changes. Runtime diagnostics still require verification after deployment; this does not claim to resolve unclassified upstream access errors.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 16, 2026 10:40pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 24 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the previously reported database-detail leak is fixed and no new actionable failures remain.

Summary

This PR improves Google connector retry behavior and preserves bounded, non-sensitive diagnostics across sync and document-processing paths.

  • Introduces shared Google API error parsing with allowlisted reason codes and bounded transient retries.
  • Distinguishes Directory membership failures from file-access failures.
  • Redacts SQL, bound parameters, and raw database causes while retaining safe driver codes.
  • Updates Gmail, Calendar, and Drive troubleshooting documentation and adds regression coverage.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Google[Google API] --> Parser[Bounded error parser]
  Parser --> Safe[Allowlisted operation, status, and reasons]
  Safe --> Retry{Transient or rate-limited?}
  Retry -->|Yes| Backoff[Bounded retry transport]
  Retry -->|No| Diagnostic[Connector diagnostic]
  Backoff --> Diagnostic
  Diagnostic --> Worker[Document worker]
  Worker --> Logs[Redacted logs]
  Worker --> State[Safe persisted processing error]
Loading

Reviews (2) · Last reviewed commit: "fix(search): sanitize in-process databas..."

Comment thread apps/sim/lib/knowledge/documents/service.ts
@waleedlatif1
waleedlatif1 force-pushed the codex/google-sync-diagnostics branch from 3e98cc0 to 51c655e Compare September 16, 2026 22:38
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 25 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 664ca82 into staging Sep 16, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/google-sync-diagnostics branch September 16, 2026 22:48

This branch was successfully deployed

1 active deployment
Preview 51c655e5 Deployed Sep 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant