fix(workflows): resolve finished resume runs on the run status endpoint - #7894
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
statusUrlpointing at it, but the resume logs under the parent run's execution ID. The status read only matched that ID through apending/claimedresume queue entry, so once the resume settled,GET /api/v2/workflows/{id}/runs/{runId}(and the v1 executions route) returned 404 foreverreadWorkflowExecutionStatusnow looks up the resume entry at any status; when it has settled and there is no log row of its own, it reads the parent run and projects it under the resume's run IDclaimedAt/queuedAt→completedAt); acompletedattempt reports the run's state (completed, failed, or paused again with the next pause context), with no end time if a later resume is still running the runfailedattempt reportsfailedwith the run's own error when the run failed, otherwise the entry'sfailureReason; it reportscancelledwhen the run was cancelled, and never exposes outputs or pause coordinatesfilesis empty and/resumeon a resume run ID doesn't workType of Change
Testing
viteston execution-status, read-workflow-run, workflow-runs, the v1 executions route, and v2 workflow routes (307 passing)bun run type-check,bun run lint,bun run check:audits,docs-manifest:checkpassingChecklist