Skip to content

improvement(credentials): allow connecting accounts with different emails - #7883

Merged
waleedlatif1 merged 1 commit into
stagingfrom
feat/connect-any-email
Sep 16, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
feat/connect-any-email

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • Allow credential-group connections, including Sim Search, to authorize provider accounts with a different email from the signed-in Sim user.
  • Remove email hints and mismatch errors while preserving provider verification, required permissions, and enrollment ownership.

Type of Change

  • Improvement

Testing

358 focused tests passed across OAuth providers, enrollment, persistence, Search access, and connection UI. App type-check, repository lint, strict API validation, and repository audits passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 16, 2026 6:36pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with the existing enrollment ownership and provider-verification boundaries intact.

Summary

This PR allows credential-group members to authorize provider accounts whose email differs from their verified Sim enrollment email while retaining the existing identity, authorization, and persistence boundaries.

  • Removes provider login hints and provider-to-Sim email equality checks.
  • Continues verifying provider identities, token subjects, OAuth state/nonces, required scopes, provider configuration, and enrollment ownership.
  • Persists the provider-attested email and subject for display and subsequent credential use.
  • Updates Slack, standard OAuth, GitHub repositories, callback messaging, enrollment UI, documentation, and focused tests.
Diagram
sequenceDiagram
  participant Member
  participant Sim as Sim enrollment
  participant Provider as OAuth provider
  participant Store as Credential store
  Member->>Sim: Start connection for bound enrollment
  Sim->>Provider: Authorization request without email hint
  Provider-->>Sim: Authorization code
  Sim->>Provider: Exchange code and verify identity
  Provider-->>Sim: Subject, provider email, tokens, and scopes
  Sim->>Sim: Check state/nonce, provider policy, scopes, and enrollment owner
  Sim->>Store: Persist grant under bound Sim enrollment
  Store-->>Member: Connection completed
Loading

Reviews (1) · Last reviewed commit: "improvement(credentials): allow connecti..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 20 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 713f247 into staging Sep 16, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the feat/connect-any-email branch September 16, 2026 18:45

This branch was previously deployed

1 inactive deployment
Preview c5a032e8 Deployed Sep 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants