fix(identity): streamline SSO settings and harden SCIM provisioning - #7581
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR reorganizes enterprise SSO settings, hardens SCIM provisioning and reconciliation behavior, adds an additive manual-access baseline migration, and expands PostgreSQL and real-HTTP regression coverage.
Confidence Score: 5/5The PR appears safe to merge, with the previous projection defect fixed and no actionable new failures identified in the subsequent changes. SCIM projection now omits invalid scalar descendants without breaking valid complex, multi-valued, extension, or exclusion projections. The SSO navigation, SAML ACS display, and RadioGroup integration remain consistent with their contracts, and the sole previous finding was manually resolved after the fix.
|
| Filename | Overview |
|---|---|
| apps/sim/ee/scim/lib/protocol/resources.ts | Correctly tightens recursive SCIM attribute projection so nonexistent scalar descendants no longer expose parent values. |
| apps/sim/ee/sso/components/sso-settings.tsx | Replaces Radix tabs with the shared radio-based tab control while preserving mounted draft state. |
| apps/sim/ee/sso/components/sso-provider-settings.tsx | Safely reads legacy provider JSON and displays custom SAML ACS overrides consistently in view and edit modes. |
| packages/emcn/src/components/chip-switch/chip-switch.tsx | Moves ChipSwitch to Radix RadioGroup semantics with controlled selection and keyboard navigation. |
| packages/db/migrations/0325_scim_manual_workspace_baseline.sql | Adds the nullable baseline needed to preserve pre-existing manual workspace access during SCIM reconciliation. |
| .github/workflows/test-build.yml | Extends PostgreSQL CI coverage and adds real-HTTP SCIM administration and provisioning checks. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
IdP[Identity provider] -->|SSO assertion| SignIn[SSO sign-in]
IdP -->|SCIM requests| Provisioning[SCIM provisioning]
Domains[Verified domains] --> SignIn
Domains --> Provisioning
Provisioning --> Membership[Organization membership]
Provisioning --> Groups[Directory groups]
Groups --> Grants[Workspace and permission-group grants]
Membership --> Policy[Session and access policy]
Grants --> Policy
Reviews (2): Last reviewed commit: "fix(identity): reuse settings controls a..." | Re-trigger Greptile
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
Type of Change
Testing
apps/sim/ee/scim/TESTING.md.Screenshots
Checklist