fix(cli): clarify login method selection - #7578
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR clarifies CLI login method selection and credential behavior.
Confidence Score: 5/5The PR appears safe to merge; the follow-up changes correct the documentation issues without introducing a new actionable defect. No outstanding blocking failure remains. TheodoreSpeaks accepted the fail-closed handling of incompatible legacy pairing responses because Copilot-scoped keys cannot authenticate the platform CLI, and the documentation now clearly states the compatibility requirement and potential need to upgrade. The unsupported
|
| Filename | Overview |
|---|---|
| packages/sim-cli/src/commands/auth.ts | Implements explicit login-method selection, validates incompatible options, and restricts pairing to platform API keys. |
| packages/sim-cli/src/auth/device-flow.ts | Simplifies approval URL generation so pairing always requests platform scope. |
| packages/sim-cli/src/commands/auth.test.ts | Adds regression coverage for explicit methods, unavailable OAuth, invalid options, remote detection, and incompatible returned keys. |
| apps/docs/content/docs/cli/authentication.mdx | Documents method selection, callback behavior, platform-pairing requirements, and supported existing-key configuration. |
| packages/sim-cli/README.md | Aligns package-level login guidance with the implemented method and credential behavior. |
Reviews (2): Last reviewed commit: "fix(cli): correct API-key authentication..." | Re-trigger Greptile
|
@cubic-dev-ai review this PR |
@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete. |
Summary
--browserlesswith--method oauth|api-key. Explicit OAuth fails if unavailable;--no-browseronly controls opening the link.login --scopeand always request a platform API key from pairing.Type of Change
Testing
Checklist