Skip to content

fix(settings): move authorized apps into General - #7577

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/authorized-apps-general
Sep 8, 2026
Merged

fix(settings): move authorized apps into General#7577
waleedlatif1 merged 1 commit into
stagingfrom
codex/authorized-apps-general

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Move Authorized apps into General settings with a Manage action and Back navigation, preserving search, pagination, and revocation.
  • Redirect existing Authorized apps settings links and update CLI and documentation guidance.

Type of Change

  • Bug fix

Testing

63 focused consent, OAuth hook, navigation, and redirect tests passed. CLI suite: 924 passed, 3 skipped. Full repository lint, all 46 audits, the block registry check, and docs-manifest validation passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 8, 2026 1:13am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1
waleedlatif1 merged commit 83544b1 into staging Sep 8, 2026
32 checks passed
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@waleedlatif1
waleedlatif1 deleted the codex/authorized-apps-general branch September 8, 2026 01:15
@cubic-dev-ai

cubic-dev-ai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR moves Authorized apps into the General settings page while preserving grant search, pagination, revocation, legacy-link redirects, and authentication-aware visibility.

  • Adds an Authorized apps management subview under General with URL-backed navigation.
  • Redirects legacy account and workspace Authorized apps routes to the new subview.
  • Removes Authorized apps from standalone settings navigation and renderers.
  • Updates CLI messages and documentation to reference the new location.
  • Adds focused tests for subview navigation, authentication-disabled behavior, and legacy redirects.

Confidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, or repository-rule findings.

No code changed since the previous review, and no new findings were introduced. The prior navigation thread is not outstanding: waleedlatif1 intentionally accepted the adjacent General history-entry tradeoff because the implementation follows the documented policy of opening with push and closing with replace, preserves unrelated URL parameters, clears detail-scoped search state, and handles direct links consistently.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/settings/components/general/general.tsx Adds the authenticated Authorized apps action and URL-backed subview under General.
apps/sim/app/workspace/[workspaceId]/settings/components/authorized-apps/authorized-apps.tsx Adapts the grant-management view for embedded navigation while preserving search and revocation.
apps/sim/app/workspace/[workspaceId]/settings/[section]/layout.tsx Redirects legacy workspace Authorized apps links to the General subview.
apps/sim/app/account/settings/[section]/page.tsx Redirects authenticated legacy account links to the new Authorized apps location.
apps/sim/components/settings/navigation.ts Removes Authorized apps as a standalone settings destination.
apps/sim/app/workspace/[workspaceId]/settings/components/general/general.test.tsx Verifies lazy loading, URL history behavior, search cleanup, and authentication-disabled visibility.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Legacy[Legacy Authorized apps URL] --> Redirect[Redirect]
  General[General settings] -->|Manage: push| Apps[Authorized apps subview]
  Redirect --> Apps
  Apps -->|Back: replace and clear search| General
  Apps --> Grants[Search, paginate, and revoke grants]
Loading

Reviews (2): Last reviewed commit: "fix(settings): move authorized apps into..." | Re-trigger Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile Please reassess the resolved navigation discussion against the documented close-with-replace, open-with-push policy in .claude/rules/sim-url-state.md:257 and the analogous settings consumers cited there. The behavior is intentional; no code changed.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant