fix(settings): move authorized apps into General - #7577
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Greptile SummaryThis PR moves Authorized apps into the General settings page while preserving grant search, pagination, revocation, legacy-link redirects, and authentication-aware visibility.
Confidence Score: 5/5The PR appears safe to merge, with no outstanding correctness, security, or repository-rule findings. No code changed since the previous review, and no new findings were introduced. The prior navigation thread is not outstanding: waleedlatif1 intentionally accepted the adjacent General history-entry tradeoff because the implementation follows the documented policy of opening with push and closing with replace, preserves unrelated URL parameters, clears detail-scoped search state, and handles direct links consistently.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/settings/components/general/general.tsx | Adds the authenticated Authorized apps action and URL-backed subview under General. |
| apps/sim/app/workspace/[workspaceId]/settings/components/authorized-apps/authorized-apps.tsx | Adapts the grant-management view for embedded navigation while preserving search and revocation. |
| apps/sim/app/workspace/[workspaceId]/settings/[section]/layout.tsx | Redirects legacy workspace Authorized apps links to the General subview. |
| apps/sim/app/account/settings/[section]/page.tsx | Redirects authenticated legacy account links to the new Authorized apps location. |
| apps/sim/components/settings/navigation.ts | Removes Authorized apps as a standalone settings destination. |
| apps/sim/app/workspace/[workspaceId]/settings/components/general/general.test.tsx | Verifies lazy loading, URL history behavior, search cleanup, and authentication-disabled visibility. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Legacy[Legacy Authorized apps URL] --> Redirect[Redirect]
General[General settings] -->|Manage: push| Apps[Authorized apps subview]
Redirect --> Apps
Apps -->|Back: replace and clear search| General
Apps --> Grants[Search, paginate, and revoke grants]
Reviews (2): Last reviewed commit: "fix(settings): move authorized apps into..." | Re-trigger Greptile
|
@greptile Please reassess the resolved navigation discussion against the documented close-with-replace, open-with-push policy in .claude/rules/sim-url-state.md:257 and the analogous settings consumers cited there. The behavior is intentional; no code changed. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
Type of Change
Testing
63 focused consent, OAuth hook, navigation, and redirect tests passed. CLI suite: 924 passed, 3 skipped. Full repository lint, all 46 audits, the block registry check, and docs-manifest validation passed.
Checklist