Skip to content

fix(browser): preserve omnibox focus and suggestions - #7572

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/investigate-blank-browser-omnibox
Sep 7, 2026
Merged

fix(browser): preserve omnibox focus and suggestions#7572
waleedlatif1 merged 1 commit into
stagingfrom
codex/investigate-blank-browser-omnibox

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Keep the browser address field focused when its suggestions open or the field is clicked again.
  • Restore click-to-open suggestions after a new tab clears an already focused address field.
  • Reuse the existing EMCN popover interaction pattern without adding UI, styles, or state.

Type of Change

  • Bug fix

Testing

  • 131 browser tests passing, including three new focus, caret, and dismissal regression tests.
  • App type-check, repository lint, lint check, 45 audits, API validation, block-registry check, and docs-manifest check passing.
  • Eight cleanup passes completed with no additional changes needed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 7, 2026 11:15pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes omnibox suggestion interactions by reinitializing a cleared suggestion query when an already-focused address field is clicked and preventing the suggestion popover from treating interaction with that input as an outside dismissal.

  • Preserves focus and caret position when reopening suggestions.
  • Restores click-to-open behavior after repeated new-tab clear commands.
  • Adds focused regression coverage for opening, repeated clicking, and outside dismissal.

Confidence Score: 5/5

The PR appears safe to merge, with the changed focus and dismissal behavior covered by targeted regression tests and no actionable defects identified.

The query reset is limited to the previously broken null-query state, repeated focused clicks retain their existing query and caret behavior, and genuine outside interactions still close and blur the omnibox.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/components/browser-session/browser-session.tsx Adjusts omnibox query initialization and popover outside-interaction handling to preserve focus and reopen suggestions correctly.
apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/components/browser-session/browser-session-ui.test.tsx Adds regression tests for pre-focus suggestion opening, repeated clear commands, caret preservation, and outside-click dismissal.

Reviews (1): Last reviewed commit: "fix(browser): preserve omnibox focus and..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit d037966 into staging Sep 7, 2026
31 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/investigate-blank-browser-omnibox branch September 7, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant