fix(browser): preserve omnibox focus and suggestions - #7572
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Greptile SummaryThis PR fixes omnibox suggestion interactions by reinitializing a cleared suggestion query when an already-focused address field is clicked and preventing the suggestion popover from treating interaction with that input as an outside dismissal.
Confidence Score: 5/5The PR appears safe to merge, with the changed focus and dismissal behavior covered by targeted regression tests and no actionable defects identified. The query reset is limited to the previously broken null-query state, repeated focused clicks retain their existing query and caret behavior, and genuine outside interactions still close and blur the omnibox.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/components/browser-session/browser-session.tsx | Adjusts omnibox query initialization and popover outside-interaction handling to preserve focus and reopen suggestions correctly. |
| apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/components/browser-session/browser-session-ui.test.tsx | Adds regression tests for pre-focus suggestion opening, repeated clear commands, caret preservation, and outside-click dismissal. |
Reviews (1): Last reviewed commit: "fix(browser): preserve omnibox focus and..." | Re-trigger Greptile
Summary
Type of Change
Testing
Checklist