improvement(redis-cleanup): schedule, async workflow, hitl base64 cache cleanup#4646
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Scheduled executions ( Reviewed by Cursor Bugbot for commit 3a4d277. Configure here. |
Greptile SummaryThis PR eagerly cleans up Redis-backed base64 file caches at workflow execution end rather than waiting for TTL expiry. The cleanup is added via
Confidence Score: 5/5Safe to merge — the changes only add eager Redis cache cleanup, and the underlying function already absorbs all errors internally. All three call sites correctly scope the cleanup to the execution ID used when populating the cache. The No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Caller
participant Executor as Workflow/Schedule/HITL Executor
participant Redis as Redis (base64 cache)
participant Storage as File Storage
Caller->>Executor: start execution
Executor->>Storage: read user files
Executor->>Redis: cache base64 (SET_BASE64_CACHE_SCRIPT)
note over Executor: workflow runs...
alt success / error
Executor-->>Caller: return result / throw
else re-pause (HITL)
Executor-->>Caller: paused event written
end
note over Executor: finally block
Executor->>Redis: cleanupExecutionBase64Cache(executionId)
Redis-->>Executor: cache entries deleted (CLEANUP_BASE64_CACHE_ENTRY_SCRIPT)
note over Executor: budget counters decremented
Reviews (2): Last reviewed commit: "address comments" | Re-trigger Greptile |
|
@greptile |
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 3a4d277. Configure here.
Summary
Base64 cache cleanup on schedule, async workflow, hitl resume on execution end instead of waiting for ttl
Type of Change
Testing
Tested manually
Checklist