Skip to content

Add a default-off "Show all fonts" escape hatch to the font pickers#114

Merged
simion merged 1 commit into
simion:mainfrom
MHohlios:feature/show-all-fonts
Jul 16, 2026
Merged

Add a default-off "Show all fonts" escape hatch to the font pickers#114
simion merged 1 commit into
simion:mainfrom
MHohlios:feature/show-all-fonts

Conversation

@MHohlios

@MHohlios MHohlios commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Follow-up to the installed-fonts filter, as discussed: a default-off escape hatch for monospace fonts that is_monospace() misses (unusual naming, missing OS/2 flags).

  • Each font picker carries a compact "Show all fonts" checkbox under its select. Both drive one shared pref (the pickers feed from the same list); tooltip clarifies the scope. Off by default, persisted, part of Reset to defaults.
  • When on, availableMonoFontsAsync sources the system: extras from the full installed family catalog instead of the monospace subset. The curated installed-only filter, dedup against curated stacks, and the Bundled/Installed optgroups are unchanged.
  • Flipping it re-merges from the cached enumeration (no re-scan). A selection made while on stays visible and re-selectable after turning it off (existing withSelectedFonts rescue).
  • Tests: pref default/persistence/reset, plus mocked-IPC coverage that showAll surfaces a non-monospace family and default mode hides it.
Screenshot 2026-07-16 at 10 07 34 AM

…font pickers

The font pickers only list families font-kit's is_monospace() approves,
which misses some legitimate monospace fonts (unusual naming, missing
OS/2 flags). Each picker now carries a small "Show all fonts" checkbox
driving one shared pref that widens the system: extras source from the
monospace subset to the full installed family catalog; the curated
installed-only filter and the Bundled/Installed optgroups are unchanged.
Off by default, participates in Reset to defaults.
@MHohlios
MHohlios force-pushed the feature/show-all-fonts branch from 9e9ecc4 to 4e8e1b5 Compare July 16, 2026 14:07
@MHohlios
MHohlios marked this pull request as ready for review July 16, 2026 14:09
@simion
simion merged commit 4230630 into simion:main Jul 16, 2026
2 checks passed
@simion

simion commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Merged, thanks.

One follow-up on main (d03c449): the "Show all fonts" row is a <label> now instead of a div with its own onClick. A label forwards text clicks to the checkbox button natively, so the stop-propagation workaround and its comment go away. Same pattern as the sandbox checkbox rows in RepositorySection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants