SG-43459 Migrate Build scene/template workflows#145
Open
carlos-villavicencio-adsk wants to merge 35 commits into
Open
SG-43459 Migrate Build scene/template workflows#145carlos-villavicencio-adsk wants to merge 35 commits into
carlos-villavicencio-adsk wants to merge 35 commits into
Conversation
2 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## ticket/SG-43456_migration_1 #145 +/- ##
==============================================================
Coverage ? 19.16%
==============================================================
Files ? 51
Lines ? 4841
Branches ? 0
==============================================================
Hits ? 928
Misses ? 3913
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
yungsiow
reviewed
Jun 18, 2026
chenm1adsk
reviewed
Jun 19, 2026
chenm1adsk
left a comment
chenm1adsk
left a comment
There was a problem hiding this comment.
Left some question of improvement that I am not sure if we should aim for in the scope of this ticket.
Comment on lines
105
to
106
| if len(actions) == 0: | ||
| actions.extend(list(mappings.get("All", []))) |
There was a problem hiding this comment.
Not introduced by this PR but as I mentioned in phase1 PR, this will change the behaviour of when to append actions in "All", we shouldn't introduce to tk-multi-loader2.
| enable_flowam = app.get_setting("enable_flowam", False) | ||
| if enable_flowam: | ||
| am_base_obj = kwargs.get("am_base_obj") | ||
| if self.parent.context.flow_project_id: |
There was a problem hiding this comment.
I feel like it is better to just create a function to group flow logic.
For example create a _flow_execute_action and called it when flow project id exists
yungsiow
reviewed
Jun 19, 2026
yungsiow
reviewed
Jun 19, 2026
yungsiow
reviewed
Jun 19, 2026
yungsiow
reviewed
Jun 19, 2026
yungsiow
reviewed
Jun 19, 2026
yungsiow
reviewed
Jun 19, 2026
yungsiow
reviewed
Jun 19, 2026
yungsiow
reviewed
Jun 19, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base branch #137
Requirements
Description
This will prevent having these workflows dependant from tk-framework-flowam.
TODO
flowam_actions.pyinfo.ymltk_core_reffromazure-pipelines.yml