Conversation
pull-request-size
Bot
added
the
size/L
openshift-ci
Bot
added
the
do-not-merge/release-note-label-needed
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
psrvere
force-pushed
the
worktree-build-upload-step-resources
branch
from
September 16, 2026 11:41
5503744 to
8d412aa
Compare
psrvere
changed the title
openshift-ci
Bot
added
release-note
and removed
do-not-merge/release-note-label-needed
Author
|
/kind feature |
openshift-ci
Bot
added
the
kind/feature
`shp build upload` created its own BuildRun and exposed only a fixed set of BuildRun fields, so a Local-source build could not request step compute resources and could not be streamed into a BuildRun created elsewhere. This closes the gap flagged when migrating OpenShift BuildConfigs (with spec.resources) to Shipwright. - --step-resources (repeatable): sets BuildRunSpec.StepResources as <step>=<limits|requests>.<resource>=<quantity>, e.g. build-and-push=limits.memory=2Gi. Wired through BuildRunSpecFromFlags, so it is also available on `build run` and `buildrun create`. - --buildrun-name: streams the local source into an existing BuildRun instead of creating one, covering any BuildRun field the CLI does not expose as a flag. Guarded against combination with creation-only flags and against source-bundle builds. Adds unit tests for the flag parser and upload flow, plus e2e cases, and regenerates the command docs. Closes: shipwright-io#415 Co-authored-by: Claude Signed-off-by: Prateek Singh Rathore <prateek.singh.rathore@gmail.com>
psrvere
force-pushed
the
worktree-build-upload-step-resources
branch
from
September 16, 2026 11:45
8d412aa to
07e9276
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #415.
shp build uploadpreviously created its own BuildRun and exposed only a fixed set of BuildRun fields as flags. As a result, a Local-source build could not request per-step compute resources, and there was no way to stream a local directory into a BuildRun created some other way. This surfaced while migrating OpenShift BuildConfigs (withspec.resources) to Shipwright with the crane plugin.This PR adds both flags proposed in the issue:
--step-resources(repeatable): setsBuildRunSpec.StepResources, using the format<step>=<limits|requests>.<resource>=<quantity>(e.g.build-and-push=limits.memory=2Gi). Repeated entries for the same step merge. Wired throughBuildRunSpecFromFlags, so it is also available onshp build runandshp buildrun create(StepResources is a BuildRun field).--buildrun-name: streams the local source into an existing BuildRun instead of creating one, covering any BuildRun field the CLI does not expose as a flag. Guarded against combination with creation-only flags, and against source-bundle builds (streaming/Local path only).Submitter Checklist
See the contributor guide for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
Co-authored-by: Claude