feat(cmd): add 'get' subcommand for build and buildrun resources - #412
mohit-bhandari45 wants to merge 2 commits into
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@kaizakin Please review this pr. |
Signed-off-by: mohit-bhandari45 <mohitbhandari852@gmail.com>
33a2640 to
8ff0a70
Compare
|
@SaschaSchwarze0 Do review this once you get time. |
kaizakin
left a comment
There was a problem hiding this comment.
please address my comments
and btw try to reduce duplicated code if possible/applicable
|
@kaizakin all your comments are resolved. |
Signed-off-by: mohit-bhandari45 <mohitbhandari852@gmail.com>
Changes
Introduced the missing
getsubcommand for bothbuildandbuildrunresource managers (shp build getandshp buildrun get):shp build get <name>: Retrieves detailed specification and status for aBuildobject (Source URL, revision, strategy, output image, registration status).shp buildrun get <name>: Retrieves detailed specification and status for aBuildRunexecution object (Build ref, status condition, start & completion times).-o jsonand-o yamlflags, as well as a default clean key-value summary table.NotFounderrors gracefully with friendly messages (e.g.Build 'xyz' not found in namespace 'default'.).pkg/shp/cmd/build/get_test.goandpkg/shp/cmd/buildrun/get_test.go(100% passing).Related Issue
Fixes #411
Type of PR
/kind feature
Submitter Checklist
Release Notes