Drop deprecated code and old wrappers - #802
Merged
Merged
Conversation
sagudev
reviewed
Aug 23, 2026
Gae24
force-pushed
the
drop-old-wrappers
branch
from
August 24, 2026 09:38
6a8ca78 to
ea0fdc5
Compare
sagudev
approved these changes
Aug 24, 2026
sagudev
left a comment
sagudev
left a comment
Member
There was a problem hiding this comment.
LGTM, but can we wait for ESR bump to land first. Because I really do not want to do another hard rebase.
Contributor
Author
Sure! |
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Gae24
force-pushed
the
drop-old-wrappers
branch
from
August 30, 2026 09:23
ea0fdc5 to
b87b2f8
Compare
alice
pushed a commit
to alice/servo
that referenced
this pull request
Aug 31, 2026
Companion PR of servo/mozjs#802, which drops deprecated code and the legacy wrappers. Now that the `safe` variants are the only ones left, some methods have been renamed back to the original names. Testing: It compiles --------- Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: It compiles
Servo PR: servo/servo#47482