feat: Add tab status indicators and refine alert and launch-spinner styling#25
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refines the serverpod_tui package-side TUI components used by serverpod start, adding per-tab activity indicators, updating alert banner action hint styling, and adjusting launch-spinner alignment for better visual consistency.
Changes:
- Added per-tab status indicators to
TabBarvia a newTabActivityenum andstatesparameter, with accompanying tests. - Restyled
AlertLinekey/label hints to match the command bar (unbracketed keys, capitalized labels, semantic coloring) and updated tests accordingly. - Adjusted
TrackedOperationWidgetspinner/text spacing to align the “Launching …” line flush-left with log text; bumped version and updated changelog.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/src/components/tab_bar_test.dart | Adds coverage for new TabBar.states indicator rendering (running/stopped/loading/none). |
| test/alert_line_test.dart | Updates/extends assertions to match new alert hint casing and bracket removal. |
| pubspec.yaml | Bumps package version to 0.7.0. |
| lib/src/components/tab_bar.dart | Introduces TabActivity, TabBar.states, and indicator rendering in _Tab. |
| lib/src/components/log_operation.dart | Tweaks spinner + label spacing for launch/operation line alignment. |
| lib/src/alert_line.dart | Restyles action hints (key/label styling and spacing) in alert banner line rendering. |
| CHANGELOG.md | Documents the new feature and styling fixes for 0.7.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marcelomendoncasoares
approved these changes
Jul 1, 2026
marcelomendoncasoares
left a comment
marcelomendoncasoares
left a comment
Collaborator
There was a problem hiding this comment.
Only one suggestion on the test, but otherwise LGTM! Feel free to merge after addressing the comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package-side changes for the
serverpod startTUI refinements in serverpod/serverpod#5412.Tab status indicators -
TabBargains an optionalstateslist (newTabActivityenum:running/loading/stopped/none) that draws a leading indicator before each tab label: green●(running), a gray spinner (loading), red◼(stopped).Alert banner hints -
AlertLineaction hints now match the bottom command bar:C Copy Esc Dismiss(no brackets, capitalized labels, key in the activation color, label in normal text).Launch spinner alignment - the active operation line (
Launching <app>...) is now flush-left with a single space after the spinner, so it lines up with the log text on both the server and Flutter app tabsChanges Made After Standup's Review