Conversation
Bump 33 transitive crates within their existing semver ranges (aho-corasick, base64, bytemuck_derive, camino, cc, clap/clap_builder/clap_derive, crc32fast, either, find-msvc-tools, futures-core/task/util, http, js-sys, log, macro_rules_attribute(+proc_macro), pastey (new transitive dep of macro_rules_attribute), pkg-config, regex-automata, rustls, rustls-webpki, syn, thiserror(+impl), time, ureq(-proto), wasm-bindgen family, web-sys, zerocopy(-derive), zlib-rs). flate2 1.1.10, hermit-abi 0.5.3 and indexmap 2.14.1 were reverted to their prior pinned versions (via `cargo update -p <crate> --precise <old>`) because they fail this repo's 7-day quarantine window (scripts/check-quarantine.sh); none carry an advisory that requires the newer version, so a plain revert is sufficient. Regenerated supply-chain/config.toml exemptions (`cargo vet regenerate exemptions`) to cover the bumped versions; imports.lock was refreshed from upstream (google/isrg/mozilla/zcash) audits at the same time, which now cover a few crates (deranged, hashbrown 0.17.1, indexmap, smallvec, unicode-segmentation) that previously needed a local exemption. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cd engine && cargo update— in-range only, no majors bumped.supply-chain/config.tomlexemptions (cargo vet regenerate exemptions) socargo vet checkpasses against the new versions;supply-chain/imports.lockwas refreshed from upstream (google/isrg/mozilla/zcash) at the same time.Bumped (33 crates, all transitive, all in-range)
Reverted for the 7-day quarantine (
scripts/check-quarantine.sh)cargo update -p <crate> --precise <old>back to the pre-update version — none carry an advisory that would require adopting the newer version immediately, so a plain revert (rather thanquarantine-allowlist.toml) was sufficient:flate21.1.10 → reverted to 1.1.9 (published 3 days ago; also reverts transitiveminiz_oxide0.9.1 → 0.8.9)hermit-abi0.5.3 → reverted to 0.5.2 (published 0 days ago)indexmap2.14.1 → reverted to 2.14.0 (published 3 days ago)Gates
cargo fmt --all --check— passcargo clippy --workspace --all-targets --all-features -- -D warnings— pass, no warningscargo test --workspace --all-features— 464 passed, 4 ignored. 2 pre-existing failures (t10_a_promotion_that_failed_schedules_its_own_retry,t10_an_unreadable_marker_is_never_recorded_as_an_observation) reproduce identically on unmodifiedmainin this sandbox — the fixtures rely onchmodblocking reads/writes, which doesn't apply when running as root, and are unrelated to this change. They should pass under CI's non-root runner.scripts/check-quarantine.sh— pass (all changed deps ≥7 days old after the 3 reverts above)cd engine && cargo vet check— pass (54 fully audited, 2 partially audited, 230 exempted)cd engine && cargo deny check— advisories ok, bans ok, licenses ok, sources ok (no new advisories introduced by this bump)Not run:
mise run accuracy/mise run accuracy-history. This sandbox's GitHub access is scoped tosend/leximeonly, anddictool fetchneedsapi.github.com/repos/google/mozcto buildengine/data/lexime.{dict,conn}from scratch — that call is rejected here, so the corpora can't be built locally. None of the bumped crates touch dictionary/tokenization/Viterbi code paths (they're compression, CLI-parsing, TLS, error-derive, and wasm-bindgen infra crates), so accuracy risk is low, but please let CI's accuracy job (which runs outside this sandbox) confirm before merging, or run it locally.Test plan
cargo deny check,cargo vet check,cargo machete)mise run accuracyandmise run accuracy-historyboth green (please confirm on this PR's checks before merging — not verified locally, see above)Generated by Claude Code