Skip to content

Don't use hardcoded path to the evmc lib#3613

Closed
qezz wants to merge 1 commit into
sei-protocol:mainfrom
ChorusOne:main
Closed

Don't use hardcoded path to the evmc lib#3613
qezz wants to merge 1 commit into
sei-protocol:mainfrom
ChorusOne:main

Conversation

@qezz

@qezz qezz commented Jun 20, 2026

Copy link
Copy Markdown

Describe your changes and provide context

The runtime.Caller(0) returns paths to the source code, not picking them up during runtime.

Testing performed to validate your change

The nodes are starting with giga executor enabled, instead of crashing trying to pick up the wrong hardcoded path to the .so file.

panic: failed to load evmone: evmc.Load("/go/src/github.com/sei-protocol/sei/giga/executor/lib/libevmone.0.12.0_linux_amd64.so"): EVMC loading error: /go/src/github.com/sei-protocol/sei/giga/executor/lib/libevmone.0.12.0_linux_amd64.so: cannot open shared object file: No such file or directory

The runtime.Caller(0) returns paths to the source code, not picking
them up during runtime.
@cursor

cursor Bot commented Jun 20, 2026

Copy link
Copy Markdown

PR Summary

Cursor Bugbot is generating a summary for commit 8c79b11. Configure here.

@m3diumrare

Copy link
Copy Markdown

This looks like it likely resolves #3578

@masih masih requested a review from sei-will June 22, 2026 10:20
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.13%. Comparing base (f83a111) to head (8c79b11).

Files with missing lines Patch % Lines
giga/executor/lib/evmlib.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3613      +/-   ##
==========================================
- Coverage   59.01%   58.13%   -0.88%     
==========================================
  Files        2224     2150      -74     
  Lines      182814   174263    -8551     
==========================================
- Hits       107893   101314    -6579     
+ Misses      65220    63949    -1271     
+ Partials     9701     9000     -701     
Flag Coverage Δ
sei-chain-pr 0.00% <0.00%> (?)
sei-db 70.41% <ø> (-0.22%) ⬇️
sei-db-state-db ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
giga/executor/lib/evmlib.go 40.00% <0.00%> (-15.56%) ⬇️

... and 75 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih

masih commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

This issue is fixed on main, in that the default executor used is geth and evmone load failure is scilently ignored. A separate PR improves the UX as well as encorporating the improvement kindly submitted by this PR.

Closing and many thanks for pointing this issue out + PR to fix 🙌

@masih masih closed this Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants