Don't use hardcoded path to the evmc lib#3613
Closed
qezz wants to merge 1 commit into
Closed
Conversation
The runtime.Caller(0) returns paths to the source code, not picking them up during runtime.
PR SummaryCursor Bugbot is generating a summary for commit 8c79b11. Configure here. |
|
This looks like it likely resolves #3578 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3613 +/- ##
==========================================
- Coverage 59.01% 58.13% -0.88%
==========================================
Files 2224 2150 -74
Lines 182814 174263 -8551
==========================================
- Hits 107893 101314 -6579
+ Misses 65220 63949 -1271
+ Partials 9701 9000 -701
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Collaborator
|
This issue is fixed on main, in that the default executor used is geth and evmone load failure is scilently ignored. A separate PR improves the UX as well as encorporating the improvement kindly submitted by this PR. Closing and many thanks for pointing this issue out + PR to fix 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
The runtime.Caller(0) returns paths to the source code, not picking them up during runtime.
Testing performed to validate your change
The nodes are starting with giga executor enabled, instead of crashing trying to pick up the wrong hardcoded path to the .so file.
panic: failed to load evmone: evmc.Load("/go/src/github.com/sei-protocol/sei/giga/executor/lib/libevmone.0.12.0_linux_amd64.so"): EVMC loading error: /go/src/github.com/sei-protocol/sei/giga/executor/lib/libevmone.0.12.0_linux_amd64.so: cannot open shared object file: No such file or directory