dynamic router switching#3581
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3581 +/- ##
==========================================
+ Coverage 59.01% 59.05% +0.03%
==========================================
Files 2224 2191 -33
Lines 182814 181825 -989
==========================================
- Hits 107893 107379 -514
+ Misses 65220 64743 -477
- Partials 9701 9703 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
PR SummaryHigh Risk Overview With Consensus-facing behavior is tightened for coordinated upgrades: AppHash / commit-info gating uses effective mode and persisted migration state ( Reviewed by Cursor Bugbot for commit 2599546. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2599546. Configure here.
| } | ||
| return fmt.Errorf("failed to build router for write mode %q: %w", targetWriteMode, err) | ||
| } | ||
| cs.migrationAdvancedThisCommit = false |
There was a problem hiding this comment.
SetWriteMode resets migration guard
Medium Severity
SetWriteMode clears migrationAdvancedThisCommit, which normally blocks a second migration batch in the same commit cycle. If it runs after GetWorkingHash (first flush) but before Commit (second flush), the next flush can advance migration again in one block, diverging AppHash from peers that only advanced once.
Triggered by learned rule: sei-db migration: guard ApplyChangeSets against double-advance per commit cycle
Reviewed by Cursor Bugbot for commit 2599546. Configure here.


Describe your changes and provide context
Add the ability to change router type at runtime. Allows us to initiate migration at times other than upgrade boundaries (assuming we have control plane infrastructure that can decide when to initiate upgrade).